Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to upload firmware in zip files #3985

Merged
merged 7 commits into from
Nov 12, 2024
Merged

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Nov 6, 2024

Fixes #3983

@robertsLando
Copy link
Member Author

@AlCalzone About tryUnzipFirmwareFile should I check the file extension first and then use it before guess ?

@coveralls
Copy link

coveralls commented Nov 6, 2024

Pull Request Test Coverage Report for Build 11797950391

Details

  • 0 of 23 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 21.086%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/mixins/InstancesMixin.js 0 1 0.0%
api/lib/ZwaveClient.ts 0 22 0.0%
Totals Coverage Status
Change from base Build 11797941997: -0.02%
Covered Lines: 3946
Relevant Lines: 19903

💛 - Coveralls

@AlCalzone
Copy link
Member

Almost correct. If ".zip" use tryUnzipFirmwareFile, otherwise use guessFirmwareFileFormat.
tryUnzipFirmwareFile does the guessing aswell, otherwise the zip file would have to be parsed twice.

@robertsLando
Copy link
Member Author

Ok so the code I wrote should be correct, right?

AlCalzone
AlCalzone previously approved these changes Nov 6, 2024
@AlCalzone
Copy link
Member

Looks good. Just need to wait for 14.1.0 to finish building.

@robertsLando robertsLando merged commit 5fecb60 into master Nov 12, 2024
9 checks passed
@robertsLando robertsLando deleted the zip-firmware branch November 12, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ZIP firmware update files
3 participants