Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): re-order Z-Wave settings, prevent setting invalid regions #3981

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

AlCalzone
Copy link
Member

This PR groups the Z-Wave settings panel a bit more logically, adds subheadings and explains some settings a bit better. Also it is no longer possible to choose "Unknown" and "Default (EU)" as default regions, since they are not a valid setting.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11685317450

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 21.095%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/items.js 0 5 0.0%
Totals Coverage Status
Change from base Build 11661884681: -0.006%
Covered Lines: 3946
Relevant Lines: 19894

💛 - Coveralls

Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsLando robertsLando changed the title feat: re-order Z-Wave settings, prevent setting invalid regions feat(ui): re-order Z-Wave settings, prevent setting invalid regions Nov 6, 2024
@robertsLando robertsLando merged commit cf7142e into master Nov 6, 2024
9 checks passed
@robertsLando robertsLando deleted the reorder-settings branch November 6, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants