fix(ui): trigger page reload on 401 (fix basic auth) #3825
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Throw exception when
401
returned from/auth-enabled
to trigger page reload. This is needed for http basic auth to work properly.Details
I run zwave-js-ui behind basic http auth and get "Unexpected end of JSON input" error after browser restart:
This happens when
401
status is returned since Chrome keeps auth only until browser restart.Typically Chrome would display the auth popup in this case but turns out it doesn't work requests made by service workers:
https://issues.chromium.org/issues/40474438
This is essentially the same issue as #3427
FWIW Without this PR, it can be "fixed" with the following Caddy config (send
302
whenAuthorization
header is missing)