Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): nodes table header from breaking line #3738

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

zackbcom
Copy link
Contributor

@zackbcom zackbcom commented Jun 2, 2024

Changes

Adjusts the headers in the nodes-table to not break lines.
Adjust minor css of headers to make it pleasant

Testing Artifacts

  • Before:
    • image
  • After:
    • image

@zackbcom zackbcom changed the title fix(ui) Nodes Table Header from Line Breaking fix: Nodes Table Header from Line Breaking Jun 2, 2024
@zackbcom zackbcom changed the title fix: Nodes Table Header from Line Breaking fix(ui): Nodes Table Header from Line Breaking Jun 2, 2024
@zackbcom zackbcom changed the title fix(ui): Nodes Table Header from Line Breaking fix(ui): nodes table header from breaking line Jun 2, 2024
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done with this! I always hated that line break on headers.

LGTM :)

@robertsLando robertsLando merged commit 93e4ecf into zwave-js:master Jun 3, 2024
4 of 8 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9347021045

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 21.163%

Totals Coverage Status
Change from base Build 9346978872: 0.0%
Covered Lines: 3899
Relevant Lines: 19593

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants