Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): use vuetify's material design palette colors for protocol color #3692

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

acshef
Copy link
Contributor

@acshef acshef commented Apr 26, 2024

This PR is intended to update the colors of the protocol icons to those of the Material design palette offered by Vuetify. This matches the color palette of the other columns in the node table.

Considerations:

  • In the spirit of an easily digestible PR, I am not addressing non-Material colors elsewhere in the ZWJS UI
  • I tried using colors.indigo.base for Protocols.ZWave, but the contrast between ZWave and ZWaveLongRange wasn't great. There isn't a good color in the material design palette that's close to the outdated rgb(0, 0, 255) color -- perhaps one of the indigo/blue accent colors would better match the original author's intention.
  • There's no requirement to adhere to the original author's intention -- it's not like we're using colors chosen by the Z-Wave Alliance to represent protocol icons, so we could pick something other than blue if it feels like those are too close to the app's primary color.

Before:
image

After:
image
image

@acshef acshef changed the title Use Vuetify's Material design palette colors for protocol color feat(ui): use vuetify's material design palette colors for protocol color Apr 26, 2024
@acshef acshef changed the title feat(ui): use vuetify's material design palette colors for protocol color fix(ui): use vuetify's material design palette colors for protocol color Apr 26, 2024
@robertsLando
Copy link
Member

Thanks @acshef !

@robertsLando robertsLando enabled auto-merge (squash) April 29, 2024 07:07
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8850151443

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 21.787%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/utils.js 0 4 0.0%
Totals Coverage Status
Change from base Build 8847191079: -0.002%
Covered Lines: 3896
Relevant Lines: 19006

💛 - Coveralls

@robertsLando robertsLando merged commit 2df5105 into zwave-js:master Apr 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants