Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mqtt-discovery): modify thermostat_2gig to use endpoint 0 #3579

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

apella12
Copy link
Contributor

@apella12 apella12 commented Feb 3, 2024

This custom device needs to be changed to use endpoint 0 after the changes #6017 and #6184 in the node-zwave-js repository. I checked all three devices that use this config and they all should be okay with endpoint 0.

This custom device needs to be changed to use endpoint 0 after the changes #6017 and #6184 in the node-zwave-js repository.  I checked all three devices that use this config and they all should be okay with endpoint 0.

Signed-off-by: Bob Eckhoff <[email protected]>
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @apella12

@robertsLando robertsLando changed the title feat(config): modify thermostat_2gig to use endpoint 0 fix(mqtt-discovery): modify thermostat_2gig to use endpoint 0 Feb 5, 2024
@robertsLando robertsLando enabled auto-merge (squash) February 5, 2024 12:45
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7768066341

  • 0 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 22.076%

Totals Coverage Status
Change from base Build 7738176768: 0.0%
Covered Lines: 3763
Relevant Lines: 18124

💛 - Coveralls

@robertsLando robertsLando merged commit 4ba9ead into zwave-js:master Feb 5, 2024
9 checks passed
@apella12 apella12 deleted the ct-101 branch February 5, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants