From bcd4554b3c9d02ca302ad83e4ad2bf1bb7c7d697 Mon Sep 17 00:00:00 2001
From: Daniel Lando <daniel.sorridi@gmail.com>
Date: Tue, 9 Mar 2021 13:37:07 +0100
Subject: [PATCH] fix(ui): show custom values and better read-only style (#853)

* fix(ui): show custom values in select too

Fixes #844

* fix: read only values style

* fix: move to scoped styles
---
 src/components/ValueId.vue | 41 ++++++++++++++++++++++++++++----------
 1 file changed, 31 insertions(+), 10 deletions(-)

diff --git a/src/components/ValueId.vue b/src/components/ValueId.vue
index 56606bb8fc8..88524ff91b1 100644
--- a/src/components/ValueId.vue
+++ b/src/components/ValueId.vue
@@ -3,13 +3,13 @@
     <v-subheader class="valueid-label">{{ label }} </v-subheader>
 
     <div v-if="!value.writeable">
-      <v-text-field
-        readonly
-        :suffix="value.unit"
-        :hint="help"
-        persistent-hint
-        v-model="parsedValue"
-      ></v-text-field>
+      <div class="readonly mt-5">
+        {{ parsedValue + (value.unit ? ' ' + value.unit : '') }}
+      </div>
+
+      <div v-if="help" class="caption mt-1">
+        {{ help }}
+      </div>
     </div>
 
     <div v-else>
@@ -106,7 +106,7 @@
 
       <v-select
         v-if="value.list && !value.allowManualEntry"
-        :items="value.states"
+        :items="items"
         :style="{
           'max-width': $vuetify.breakpoint.smAndDown
             ? '280px'
@@ -122,11 +122,17 @@
         :append-outer-icon="!disable_send ? 'send' : null"
         v-model="value.newValue"
         @click:append-outer="updateValue(value)"
-      ></v-select>
+      >
+        <template v-slot:selection="{ item }">
+          <span>
+            {{ itemText(selectedItem || item) }}
+          </span>
+        </template>
+      </v-select>
 
       <v-combobox
         v-if="value.list && value.allowManualEntry"
-        :items="value.states"
+        :items="items"
         :style="{
           'max-width': $vuetify.breakpoint.smAndDown
             ? '280px'
@@ -211,6 +217,11 @@
   padding-left: 0;
   margin-bottom: -10px;
 }
+
+.readonly {
+  font-size: x-large;
+  font-weight: bold;
+}
 </style>
 
 <script>
@@ -239,6 +250,16 @@ export default {
       if (!this.value.states) return null
       else return this.value.states.find(s => s.value === value)
     },
+    items () {
+      if (this.selectedItem) {
+        return this.value.states
+      } else {
+        return [
+          { value: this.value.newValue, text: 'Custom' },
+          ...this.value.states
+        ]
+      }
+    },
     label () {
       return '[' + this.value.id + '] ' + this.value.label
     },