From 449b03a62f353b5c900e1879956ccab459bf56d3 Mon Sep 17 00:00:00 2001 From: Daniel Lando Date: Tue, 30 Jun 2020 14:34:00 +0200 Subject: [PATCH] fix: remove refreshNodeInfo and auto heal options (#603) --- README.md | 32 +++++++++++++++----------------- lib/ZwaveClient.js | 5 ----- src/App.vue | 5 ++++- src/components/Settings.vue | 32 -------------------------------- 4 files changed, 19 insertions(+), 55 deletions(-) diff --git a/README.md b/README.md index 80d79c5bc2c..64ea228484f 100644 --- a/README.md +++ b/README.md @@ -36,27 +36,28 @@ After a [discussion](https://github.com/OpenZWave/Zwave2Mqtt/issues/201) with Op ## ๐Ÿ“– Table of contents - [Zwave To MQTT](#zwave-to-mqtt) - - [!! ATTENTION !!](#-attention) - - [๐Ÿ“– Table of contents](#%f0%9f%93%96-table-of-contents) - - [:electric_plug: Installation](#electricplug-installation) - - [DOCKER :tada: way](#docker-tada-way) + - [!! ATTENTION](#-attention) + - [๐Ÿ“– Table of contents](#-table-of-contents) + - [:electric_plug: Installation](#-installation) + - [DOCKER :tada: way](#docker--way) - [Kubernetes way](#kubernetes-way) - [NodeJS or PKG version](#nodejs-or-pkg-version) - [Reverse Proxy Setup](#reverse-proxy-setup) - - [:nerd_face: Development](#nerdface-development) - - [:wrench: Usage](#wrench-usage) + - [:nerd_face: Development](#-development) + - [Developing against a different backend](#developing-against-a-different-backend) + - [:wrench: Usage](#-usage) - [Zwave](#zwave) - [MQTT](#mqtt) - [Gateway](#gateway) - [Special topics](#special-topics) - [Gateway values table](#gateway-values-table) - - [:file_folder: Nodes Management](#filefolder-nodes-management) + - [:file_folder: Nodes Management](#-nodes-management) - [Add a node](#add-a-node) - [Remove a node](#remove-a-node) - [Replace failed node](#replace-failed-node) - [Remove a failed node](#remove-a-failed-node) - - [:star: Features](#star-features) - - [:robot: Home Assistant integration (BETA)](#robot-home-assistant-integration-beta) + - [:star: Features](#๏ธ-features) + - [:robot: Home Assistant integration (BETA)](#-home-assistant-integration-beta) - [Components management](#components-management) - [Rediscover Node](#rediscover-node) - [Edit existing component](#edit-existing-component) @@ -66,14 +67,14 @@ After a [discussion](https://github.com/OpenZWave/Zwave2Mqtt/issues/201) with Op - [Thermostats](#thermostats) - [Fans](#fans) - [Thermostats with Fans](#thermostats-with-fans) - - [:gift: MQTT APIs](#gift-mqtt-apis) + - [:gift: MQTT APIs](#-mqtt-apis) - [Zwave Events](#zwave-events) - [Example](#example) - [Zwave APIs](#zwave-apis) - [Custom APIs](#custom-apis) - [Set values](#set-values) - [Broadcast](#broadcast) - - [:camera: Screenshots](#camera-screenshots) + - [:camera: Screenshots](#-screenshots) - [Settings](#settings) - [Control Panel](#control-panel) - [Groups associations](#groups-associations) @@ -81,9 +82,9 @@ After a [discussion](https://github.com/OpenZWave/Zwave2Mqtt/issues/201) with Op - [Mesh](#mesh) - [Debug](#debug) - [Health check endpoints](#health-check-endpoints) - - [:question: FAQ](#question-faq) - - [:pray: Thanks](#pray-thanks) - - [:pencil: TODOs](#pencil-todos) + - [:question: FAQ](#-faq) + - [:pray: Thanks](#-thanks) + - [:pencil: TODOs](#-todos) - [:bowtie: Author](#bowtie-author) ## :electric_plug: Installation @@ -210,9 +211,6 @@ Zwave settings: - **Network key** (Optional): Zwave network key if security is enabled. The correct format is `"0xCA,0xFE,0xBA,0xBE,.... "` (16 bytes total) - **Logging**: Enable/Disable Openzwave Library logging - **Save configuration**: Store zwave configuration in `zwcfg_.xml` and `zwscene.xml` files this is needed for persistent node information like node name and location -- **Refresh Node Info**: Enable this to automatically call `refreshNodeInfo` api against all nodes to force all nodes refreshing their configuration -- **Auto Heal Network**: Enable this to schedule automatic network heals to a specfic time -- **Heal hours**: When auto heal is enabled, specified the hours at which `healNetwork` will be daily triggered (0-23) - **Poll interval**: Interval in milliseconds between polls (should not be less than 1s per device) - **Commands timeout**: Seconds to wait before automatically stop inclusion/exclusion - **Configuration Path**: The path to Openzwave devices config db diff --git a/lib/ZwaveClient.js b/lib/ZwaveClient.js index 65e4a3a8e21..73a7496e212 100644 --- a/lib/ZwaveClient.js +++ b/lib/ZwaveClient.js @@ -590,17 +590,12 @@ function scanComplete () { for (var i = 0; i < nodes.length; i++) { this.getGroups(nodes[i].node_id) nodes[i].neighborns = this.client.getNodeNeighbors(nodes[i].node_id) - if (this.cfg.refreshNodeInfo) { - this.client.refreshNodeInfo(nodes[i].node_id) - } } if (this.cfg.saveConfig && typeof this.client.writeConfig === 'function') { this.client.writeConfig() } - this.scheduleHeal() - debug('Network scan complete. Found:', nodes.length, 'nodes') } diff --git a/src/App.vue b/src/App.vue index 4b651ad4a24..e39f8131268 100644 --- a/src/App.vue +++ b/src/App.vue @@ -22,12 +22,15 @@ v-for="item in pages" :key="item.title" :to="item.path == '#' ? '' : item.path" + :color="item.path === $route.path ? 'primary' : ''" > {{ item.icon }} - {{ item.title }} + {{ + item.title + }} diff --git a/src/components/Settings.vue b/src/components/Settings.vue index 7c5899a2530..3f4aaa65d77 100644 --- a/src/components/Settings.vue +++ b/src/components/Settings.vue @@ -67,35 +67,6 @@ v-model="zwave.assumeAwake" > - - - - - - - - - { - return (value >= 0 && value <= 23) || 'Insert a value between 0-23' - }, validName: value => { return ( !/[!@#$%^&*)(+=:,;"'\\|?{}ยฃยฐยง<>[\]/.\s]/g.test(value) ||