Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): updates to AEON Labs Minimote #7544

Merged
merged 5 commits into from
Jan 13, 2025

Conversation

kpine
Copy link
Contributor

@kpine kpine commented Jan 12, 2025

Updates to fix zwave-js/zwave-js-ui#4088:

  • Parameter 250 should be write-only as device does not respond to queries (params 241-249 already write-only)
  • Force support for Scene Activation CC so static value IDs are persisted

Additionally:

  • Import manufacturer templates via root directory
  • Add wakeup instructions

@zwave-js-assistant zwave-js-assistant bot added the config ⚙ Configuration issues or updates label Jan 12, 2025
@kpine kpine marked this pull request as ready for review January 12, 2025 08:01
Copy link
Member

@AlCalzone AlCalzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if the import paths stayed local. Or why is this needed?

@kpine
Copy link
Contributor Author

kpine commented Jan 12, 2025

I'd prefer if the import paths stayed local. Or why is this needed?

I thought it was necessary in order to write your own device config override, without copying the template too. Is that wrong?

@AlCalzone
Copy link
Member

That's correct. It's not needed for the built in configs though.

@kpine
Copy link
Contributor Author

kpine commented Jan 12, 2025

Ok, I'll revert it.

It would still be nice to be able to avoid duplicating the template structure for an override, which I thought was the whole point of #6067.

@AlCalzone
Copy link
Member

Yeah, I need to revisit the fallback logic to also look for the manufacturer template when loaded from a relative path.

@AlCalzone AlCalzone merged commit 6aa7f4d into zwave-js:master Jan 13, 2025
25 checks passed
@kpine kpine deleted the minimote-scene-activation branch January 13, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config ⚙ Configuration issues or updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aeotec Minimote Scene Mode Setting Not Retained After Re-Interview
2 participants