Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secure notifications for WSL #767

Open
neiljp opened this issue Aug 9, 2020 · 4 comments
Open

Add secure notifications for WSL #767

neiljp opened this issue Aug 9, 2020 · 4 comments
Labels
area: notifications enhancement New feature or request help wanted This issue should be clear enough to work on high priority should be done as soon as possible platform: WSL
Milestone

Comments

@neiljp
Copy link
Collaborator

neiljp commented Aug 9, 2020

WSL notifications were removed in 0.5.2. We should aim to add back a secure version.

@neiljp neiljp added the enhancement New feature or request label Aug 9, 2020
@neiljp neiljp added this to the Next Release milestone Aug 9, 2020
@neiljp neiljp added the high priority should be done as soon as possible label Aug 15, 2020
@zee-bit
Copy link
Member

zee-bit commented Mar 28, 2021

For reference: ea8321d is the commit that removed notifications on WSL and secured it on Linux & macOS.

@zee-bit
Copy link
Member

zee-bit commented Mar 28, 2021

@neiljp But, I don't understand the security flaw in WSL notifications. I just tested it myself, and although the notifications work fine, the terminal's display breaks(sort-of), with all the text getting exceedingly small. Is this the reason for removing notifications in WSL or was there some other major security-issue?

PS: There is a feature request for this already filed in WSL's github page here.

@neiljp
Copy link
Collaborator Author

neiljp commented Apr 5, 2021

The issue is the handling of the necessary quoting, which is/was not clear.

@zulipbot
Copy link
Member

Hello @zulip/server-notifications members, this issue was labeled with the "area: notifications" label, so you may want to check it out!

@neiljp neiljp added the help wanted This issue should be clear enough to work on label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: notifications enhancement New feature or request help wanted This issue should be clear enough to work on high priority should be done as soon as possible platform: WSL
Projects
None yet
Development

No branches or pull requests

3 participants