Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 24-bit theme support #282

Closed
rht opened this issue Jan 28, 2019 · 5 comments
Closed

Add 24-bit theme support #282

rht opened this issue Jan 28, 2019 · 5 comments

Comments

@rht
Copy link
Contributor

rht commented Jan 28, 2019

This is a tracking issue for urwid/urwid#284. Once merged, I will extend gruvbox to 24-bit, and also this will make adding other true color themes easier.

@tonycpsu
Copy link

tonycpsu commented Apr 5, 2019

@rht : I've merged the PR. Can't say when a release will go out, but you can at least point to urwid master now.

@rht
Copy link
Contributor Author

rht commented Apr 5, 2019

Finally!

@Ezio-Sarthak
Copy link
Member

Ezio-Sarthak commented Apr 14, 2021

This would be as easy as adding a flag 2**24 in --color-depth argument.

We could also discuss here adding 88 too, though the default dark view for it doesn't seem readable at all :)

All the options for urwid's set_terminal_properties could be seen here

@neiljp
Copy link
Collaborator

neiljp commented Apr 19, 2021

Given the need for color-depth/theme compatibility after #998, I don''t mind if we leave this open to resolve the literal issue title, or close and break up into smaller issues - but I'd definitely like something open to track the incomplete support we're at right now, useful as it is already as an intermediate state 👍

@neiljp neiljp changed the title Add 24-bit themes Add 24-bit theme support Jul 7, 2021
@neiljp
Copy link
Collaborator

neiljp commented Jul 7, 2021

I'm going to close this since we now support 24-bit features in themes, even if not every built-in theme has a 24-bit-specific set of colors - ie. we need to add those values to DefaultColor if we want them to be more specific (as of #1051). The latter PR means we also don't need 24-bit-specific themes (ie. gruvbox + gruvbox24), which makes things much simpler.

See #1069 for tracking follow-up.

@neiljp neiljp closed this as completed Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants