Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify the two platform's ComposeBox code #3095

Merged
merged 3 commits into from
Nov 1, 2018
Merged

Unify the two platform's ComposeBox code #3095

merged 3 commits into from
Nov 1, 2018

Commits on Nov 1, 2018

  1. compose box: Fix a nullability nit in type signature. 

    The logic here is already correct, with a condition just under this;
just need to make the signature agree.

This issue is found by Flow when we unify the ComposeBox files,
coming soon -- Flow unfortunately doesn't check *.android.js.
    @gnprice
    gnprice committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    711e786 View commit details
    Browse the repository at this point in the history

  2. compose box: Unify two platforms' code. 

    Closes zulip#3017.  Fixes zulip#3053.

Remove the iOS code which was our old 'controlled' version and
keep the new Android 'uncontrolled' version.

While iOS does not have the extreme performance issues the Android
app had because of bugs in React Native, it is still faster to not
have the component controlled - a controlled component would block
any time the UI thread blocks.

Another big benefit is removing the need to support two versions.
    @borisyankov @gnprice
    borisyankov authored and gnprice committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    edf692d View commit details
    Browse the repository at this point in the history

  3. Input etc: Fix small type issues on TextInput refs. 

    Resolving these `any`s into the proper type shows a couple of spots
where we should be checking for null.  Not sure if these cases can
actually be exercised to cause a live bug -- but this is the easiest
way to be sure.

Also remove the `MultilineInput#textInput` property, which doesn't
seem to be ever set; presumably left behind by a past refactor.
    @gnprice
    gnprice committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    afdb464 View commit details
    Browse the repository at this point in the history