Unify the two platform's ComposeBox code #3095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borisyankov
changed the title
borisyankov
force-pushed
the
unify-compose-box
branch
from
0611b9e
to
a4a8d5c
Compare
The logic here is already correct, with a condition just under this; just need to make the signature agree. This issue is found by Flow when we unify the ComposeBox files, coming soon -- Flow unfortunately doesn't check *.android.js.
borisyankov
force-pushed
the
unify-compose-box
branch
from
a4a8d5c
to
b936771
Compare
Closes zulip#3017. Fixes zulip#3053. Remove the iOS code which was our old 'controlled' version and keep the new Android 'uncontrolled' version. While iOS does not have the extreme performance issues the Android app had because of bugs in React Native, it is still faster to not have the component controlled - a controlled component would block any time the UI thread blocks. Another big benefit is removing the need to support two versions.
Resolving these `any`s into the proper type shows a couple of spots where we should be checking for null. Not sure if these cases can actually be exercised to cause a live bug -- but this is the easiest way to be sure. Also remove the `MultilineInput#textInput` property, which doesn't seem to be ever set; presumably left behind by a past refactor.
gnprice
force-pushed
the
unify-compose-box
branch
from
b936771
to
afdb464
Compare
|
Merged -- thanks @borisyankov ! I believe #2434 was actually fixed by the RN v0.57 upgrade earlier today -- but the difference doesn't matter, of course. Glad they're all fixed. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3017. Fixes #2434. Fixes #3053.
Remove the iOS code which was our old 'controlled' version and
keep the new Android 'uncontrolled' version.
While iOS does not have the extreme performance issues the Android
app had because of bugs in React Native, it is still faster to not
have the component controlled - a controlled component would block
any time the UI thread blocks.
Another big benefit is removing the need to support two versions.