Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocorrect on iOS Compose Input #3053

Closed
armaanahluwalia opened this issue Oct 13, 2018 · 4 comments
Closed

Autocorrect on iOS Compose Input #3053

armaanahluwalia opened this issue Oct 13, 2018 · 4 comments
Assignees
@borisyankov
Labels
a-compose/send Compose box, autocomplete, camera/upload, outbox, sending a-iOS

Comments

@armaanahluwalia
Copy link
Collaborator

armaanahluwalia commented Oct 13, 2018 •
edited
Loading

Autocorrect does not behave as expected on the iOS compose message input. Basically this is very easy to reproduce. See the video for a comparison of behavior on iMessage and Zulip.

Ideally Zulip would be able to autocorrect in the middle of a sentence like iMessage does.

https://streamable.com/8w70j
https://streamable.com/glcz7

If you notice at the end of the second video the cursor jumps to the end. That happened when I tried to type a character it wasn't me moving the cursor manually. It seems to lose its place ( this is not as easily repro-able as the autocorrect problem and may be related to #3052 )

Seen on on iOS 18.0.99
@armaanahluwalia armaanahluwalia mentioned this issue Oct 13, 2018
Closed
@gnprice
Copy link
Member

gnprice commented Oct 18, 2018

Thanks for the report and the clear screencaps!

I suspect this is the same underlying issue as #2434 , though I don't understand this subsystem well enough to be confident that's the case.

That issue should be fixed in RN v0.57. Would you try the tip of #2789 (which upgrades us to that version) and see if this issue still reproduces there? (And if it does, also try reproducing #2434 to confirm I haven't misunderstood something there?) If we're lucky, that does fix it.

@gnprice gnprice added a-iOS a-compose/send Compose box, autocomplete, camera/upload, outbox, sending labels Oct 18, 2018
borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Oct 18, 2018
@borisyankov
composebox: Unify two platform's code
de2c39d 
Fixes zulip#2434
Fixes zulip#3053

Remove the iOS code which was our old 'controlled' version and
keep the new Android 'uncontrolled' version.

While iOS does not have the extreme performance issues the Android
app had because of bugs in React Native, it is still faster to not
have the component controlled - a controlled compoennt would block
any time the UI thread blocks.

Another big benefit is removing the need to support two versions.
@borisyankov
Copy link
Contributor

I added the composebox: Unify two platform's code commit to the upgrade PR.
I did test the very same example @armaanahluwalia gave and it works as expected with it.

borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Oct 21, 2018
@borisyankov
composebox: Unify two platform's code
7512f67 
Fixes zulip#2434
Fixes zulip#3053

Remove the iOS code which was our old 'controlled' version and
keep the new Android 'uncontrolled' version.

While iOS does not have the extreme performance issues the Android
app had because of bugs in React Native, it is still faster to not
have the component controlled - a controlled compoennt would block
any time the UI thread blocks.

Another big benefit is removing the need to support two versions.
borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Oct 23, 2018
@borisyankov
composebox: Unify two platform's code
72ee1df 
Fixes zulip#2434
Fixes zulip#3053

Remove the iOS code which was our old 'controlled' version and
keep the new Android 'uncontrolled' version.

While iOS does not have the extreme performance issues the Android
app had because of bugs in React Native, it is still faster to not
have the component controlled - a controlled compoennt would block
any time the UI thread blocks.

Another big benefit is removing the need to support two versions.
borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Oct 23, 2018
@borisyankov
composebox: Unify two platform's code
7de38be 
Fixes zulip#2434
Fixes zulip#3053

Remove the iOS code which was our old 'controlled' version and
keep the new Android 'uncontrolled' version.

While iOS does not have the extreme performance issues the Android
app had because of bugs in React Native, it is still faster to not
have the component controlled - a controlled compoennt would block
any time the UI thread blocks.

Another big benefit is removing the need to support two versions.
@gnprice gnprice added a-compose/send Compose box, autocomplete, camera/upload, outbox, sending and removed a-compose/send Compose box, autocomplete, camera/upload, outbox, sending labels Oct 23, 2018
borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Oct 23, 2018
@borisyankov
composebox: Unify two platform's code
994a786 
Fixes zulip#2434
Fixes zulip#3053

Remove the iOS code which was our old 'controlled' version and
keep the new Android 'uncontrolled' version.

While iOS does not have the extreme performance issues the Android
app had because of bugs in React Native, it is still faster to not
have the component controlled - a controlled compoennt would block
any time the UI thread blocks.

Another big benefit is removing the need to support two versions.
borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Oct 24, 2018
@borisyankov
composebox: Unify two platform's code
8abacae 
Fixes zulip#2434
Fixes zulip#3053

Remove the iOS code which was our old 'controlled' version and
keep the new Android 'uncontrolled' version.

While iOS does not have the extreme performance issues the Android
app had because of bugs in React Native, it is still faster to not
have the component controlled - a controlled compoennt would block
any time the UI thread blocks.

Another big benefit is removing the need to support two versions.
borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Oct 24, 2018
@borisyankov
composebox: Unify two platform's code
9abc427 
Fixes zulip#2434
Fixes zulip#3053

Remove the iOS code which was our old 'controlled' version and
keep the new Android 'uncontrolled' version.

While iOS does not have the extreme performance issues the Android
app had because of bugs in React Native, it is still faster to not
have the component controlled - a controlled compoennt would block
any time the UI thread blocks.

Another big benefit is removing the need to support two versions.
borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Oct 24, 2018
@borisyankov
composebox: Unify two platform's code
5288594 
Fixes zulip#2434
Fixes zulip#3053

Remove the iOS code which was our old 'controlled' version and
keep the new Android 'uncontrolled' version.

While iOS does not have the extreme performance issues the Android
app had because of bugs in React Native, it is still faster to not
have the component controlled - a controlled compoennt would block
any time the UI thread blocks.

Another big benefit is removing the need to support two versions.
borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Oct 25, 2018
@borisyankov
composebox: Unify two platform's code
b9a4b4a 
Fixes zulip#2434
Fixes zulip#3053

Remove the iOS code which was our old 'controlled' version and
keep the new Android 'uncontrolled' version.

While iOS does not have the extreme performance issues the Android
app had because of bugs in React Native, it is still faster to not
have the component controlled - a controlled compoennt would block
any time the UI thread blocks.

Another big benefit is removing the need to support two versions.
borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Oct 31, 2018
@borisyankov
composebox: Unify two platform's code
46234e9 
Fixes zulip#2434
Fixes zulip#3053

Remove the iOS code which was our old 'controlled' version and
keep the new Android 'uncontrolled' version.

While iOS does not have the extreme performance issues the Android
app had because of bugs in React Native, it is still faster to not
have the component controlled - a controlled compoennt would block
any time the UI thread blocks.

Another big benefit is removing the need to support two versions.
borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Oct 31, 2018
@borisyankov
composebox: Unify two platform's code
1ba4287 
Fixes zulip#2434
Fixes zulip#3053

Remove the iOS code which was our old 'controlled' version and
keep the new Android 'uncontrolled' version.

While iOS does not have the extreme performance issues the Android
app had because of bugs in React Native, it is still faster to not
have the component controlled - a controlled compoennt would block
any time the UI thread blocks.

Another big benefit is removing the need to support two versions.
@gnprice
Copy link
Member

gnprice commented Nov 1, 2018

And master is now on RN v0.57, after merging #2789!

Our belief above was that that would fix this issue. (Even without any further changes.) @armaanahluwalia or @borisyankov , would you give it a quick check to confirm whether it still reproduces?

borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Nov 1, 2018
@borisyankov
composebox: Unify two platform's code
013ad6e 
Fixes zulip#2434
Fixes zulip#3053

Remove the iOS code which was our old 'controlled' version and
keep the new Android 'uncontrolled' version.

While iOS does not have the extreme performance issues the Android
app had because of bugs in React Native, it is still faster to not
have the component controlled - a controlled compoennt would block
any time the UI thread blocks.

Another big benefit is removing the need to support two versions.
borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Nov 1, 2018
@borisyankov
composebox: Unify two platform's code.
0611b9e 
Resolves zulip#3017, Fixes zulip#2434, Fixes zulip#3053

Remove the iOS code which was our old 'controlled' version and
keep the new Android 'uncontrolled' version.

While iOS does not have the extreme performance issues the Android
app had because of bugs in React Native, it is still faster to not
have the component controlled - a controlled compoennt would block
any time the UI thread blocks.

Another big benefit is removing the need to support two versions.
@borisyankov borisyankov mentioned this issue Nov 1, 2018
Merged
@gnprice gnprice added the review label Nov 1, 2018
borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Nov 1, 2018
@borisyankov
composebox: Unify two platform's code.
a4a8d5c 
Resolves zulip#3017, Fixes zulip#2434, Fixes zulip#3053

Remove the iOS code which was our old 'controlled' version and
keep the new Android 'uncontrolled' version.

While iOS does not have the extreme performance issues the Android
app had because of bugs in React Native, it is still faster to not
have the component controlled - a controlled compoennt would block
any time the UI thread blocks.

Another big benefit is removing the need to support two versions.
borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Nov 1, 2018
@borisyankov
composebox: Unify two platform's code.
b936771 
Closes zulip#3017. Fixes zulip#2434. Fixes zulip#3053.

Remove the iOS code which was our old 'controlled' version and
keep the new Android 'uncontrolled' version.

While iOS does not have the extreme performance issues the Android
app had because of bugs in React Native, it is still faster to not
have the component controlled - a controlled compoennt would block
any time the UI thread blocks.

Another big benefit is removing the need to support two versions.
gnprice pushed a commit to borisyankov/zulip-mobile that referenced this issue Nov 1, 2018
@borisyankov @gnprice
compose box: Unify two platforms' code.
edf692d 
Closes zulip#3017.  Fixes zulip#3053.

Remove the iOS code which was our old 'controlled' version and
keep the new Android 'uncontrolled' version.

While iOS does not have the extreme performance issues the Android
app had because of bugs in React Native, it is still faster to not
have the component controlled - a controlled component would block
any time the UI thread blocks.

Another big benefit is removing the need to support two versions.
@gnprice gnprice removed the review label Nov 1, 2018
@gnprice
Copy link
Member

gnprice commented Nov 1, 2018

Well anyway, #3095 now merged too to fix the issue. Thanks again @armaanahluwalia for reporting this!

@gnprice gnprice mentioned this issue Nov 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@borisyankov borisyankov

Labels
a-compose/send Compose box, autocomplete, camera/upload, outbox, sending a-iOS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gnprice @armaanahluwalia @borisyankov