Text input gets very slow on some Android devices #2589

borisyankov · 2018-05-30T10:13:07Z

On some Android devices, in some specific cases, the 'compose' input responds very slowly to a point of being unusable.
Reported here:
https://chat.zulip.org/#narrow/stream/48-mobile/topic/speed

The issue was reproduced on Pixel 2, so it is not a purely performance problem.

Very likely, it is related to:
facebook/react-native#19126

The fix then seems to be to make our compose box not-controlled.

This is not a bad idea as it will be a performance improvement regardless of the specific bug encountered, and something I wanted to do before this issue was reported.

This is the beginning of a general performance improvement and also a fix for zulip#2589

This is the beginning of a general performance improvement and also a fix for #2589

This is the beginning of a general performance improvement and also a fix for zulip#2589

gnprice · 2018-06-09T04:32:06Z

An update: a couple of days ago (2018-06-06) we released a fix for this to all users through the Play Store, as version 13.5.89.

That version is in this repo (as a tag, and on a stable branch) but not merged to master; it's a preliminary version of #2595 which solves this Android-only problem (working around an Android-only bug in React Native) nicely, but in turn triggers a different, iOS-only bug in React Native.

I'm leaving this issue open here until we have a fix merged into master, though it's already fixed for users.

This is the beginning of a general performance improvement and also a fix for zulip#2589

Fixes zulip#2589 * make sure we do update input's initial values using `updateTextInput` in `componentDidMount` * remove the `value={...}` props that make the inputs controlled

Fixes zulip#2589 Now both message and topic inputs are updated regardless of wether they are controlled or not we remove the `value={...}`. * make sure we do update input's initial values using `updateTextInput` in `componentDidMount`

Fixes zulip#2589 Now both message and topic inputs are updated regardless of wether they are controlled or not we remove the `value={...}`.

Fixes zulip#2589 Remove the `value={topic}` from topic text input making it an uncontrolled component. To replicate the previous behavior: * initialze at the start in `componentDidMount` * make sure the topic input text is updated when we focus on a the message input (it is invisible until then) * change the text on picking a topic autocomplete suggestion

We want to make the compose box uncontrolled. Instead of using the `value` property to change the message input's and topic input's text, we will call `setNativeProps` on a reference to the underlying control. Currently on iOS there is a React Native bug that affects uncontrolled inputs: facebook/react-native#18272 On the other hand, in order to fix zulip#2589 we're eager to switch to an uncontrolled input at least on Android, in order to avoid the (different) underlying React Native bug that causes that. So for now, as a suboptimal solution, we will support two versions of the component. For iOS it will remain unchanged, and we'll modify the Android version of the file in subsequent commits.

Remove the `value={topic}` from topic text input, making it an uncontrolled component. To replicate the previous behavior: * initialize at the start in `componentDidMount` * make sure the topic input text is updated when we focus on the message input (it is invisible until then) * change the text on picking a topic autocomplete suggestion Fixes zulip#2589.

We want to make the compose box uncontrolled. Instead of using the `value` property to change the message input's and topic input's text, we will call `setNativeProps` on a reference to the underlying control. Currently on iOS there is a React Native bug that affects uncontrolled inputs: facebook/react-native#18272 On the other hand, in order to fix #2589 we're eager to switch to an uncontrolled input at least on Android, in order to avoid the (different) underlying React Native bug that causes that. So for now, as a suboptimal solution, we will support two versions of the component. For iOS it will remain unchanged, and we'll modify the Android version of the file in subsequent commits.

Remove the `value={topic}` from topic text input, making it an uncontrolled component. To replicate the previous behavior: * initialize at the start in `componentDidMount` * make sure the topic input text is updated when we focus on the message input (it is invisible until then) * change the text on picking a topic autocomplete suggestion Fixes #2589.

We want to make the compose box uncontrolled. Instead of using the `value` property to change the message input's and topic input's text, we will call `setNativeProps` on a reference to the underlying control. Currently on iOS there is a React Native bug that affects uncontrolled inputs: facebook/react-native#18272 On the other hand, in order to fix zulip#2589 we're eager to switch to an uncontrolled input at least on Android, in order to avoid the (different) underlying React Native bug that causes that. So for now, as a suboptimal solution, we will support two versions of the component. For iOS it will remain unchanged, and we'll modify the Android version of the file in subsequent commits.

Remove the `value={topic}` from topic text input, making it an uncontrolled component. To replicate the previous behavior: * initialize at the start in `componentDidMount` * make sure the topic input text is updated when we focus on the message input (it is invisible until then) * change the text on picking a topic autocomplete suggestion Fixes zulip#2589.

borisyankov added the bug label May 30, 2018

borisyankov self-assigned this May 30, 2018

zulipbot added the zz-in progress label May 30, 2018

borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue May 30, 2018

Change compose box inputs from controlled to 'not controlled'

57f98d0

This is the beginning of a general performance improvement and also a fix for zulip#2589

borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue May 30, 2018

Change compose box inputs from controlled to 'not controlled'

a936477

This is the beginning of a general performance improvement and also a fix for zulip#2589

borisyankov mentioned this issue May 30, 2018

Compose box uncontrolled #2595

Closed

gnprice changed the title ~~Text input is slow on some Android devices~~ Text input gets very slow on some Android devices May 30, 2018

gnprice added the a-Android label May 30, 2018

borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Jun 4, 2018

Change compose box inputs from controlled to 'not controlled'

ee6a8d5

This is the beginning of a general performance improvement and also a fix for zulip#2589

borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Jun 5, 2018

Change compose box inputs from controlled to 'not controlled'

276dd6e

This is the beginning of a general performance improvement and also a fix for zulip#2589

borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Jun 5, 2018

Change compose box inputs from controlled to 'not controlled'

2f360c5

This is the beginning of a general performance improvement and also a fix for zulip#2589

gnprice pushed a commit that referenced this issue Jun 6, 2018

Change compose box inputs from controlled to 'not controlled'

5dbb9c8

This is the beginning of a general performance improvement and also a fix for #2589

borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Jun 7, 2018

Change compose box inputs from controlled to 'not controlled'

4f18ad8

This is the beginning of a general performance improvement and also a fix for zulip#2589

borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Jun 7, 2018

Change compose box inputs from controlled to 'not controlled'

b265be4

This is the beginning of a general performance improvement and also a fix for zulip#2589

borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Jun 11, 2018

Change compose box inputs from controlled to 'not controlled'

7b36e23

This is the beginning of a general performance improvement and also a fix for zulip#2589

borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Jun 12, 2018

Change compose box inputs from controlled to 'not controlled'

f01e332

This is the beginning of a general performance improvement and also a fix for zulip#2589

borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Jun 13, 2018

Change compose box inputs from controlled to 'not controlled'

58de5b0

This is the beginning of a general performance improvement and also a fix for zulip#2589

gnprice added the upstream: RN Issues related to an issue in React Native label Jun 14, 2018

gnprice mentioned this issue Jun 14, 2018

Prolonged chatting results in frame drops and chat screen hanging #2292

Closed

gnprice added this to the v14.x milestone Jun 20, 2018

borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Jun 21, 2018

Change compose box inputs from controlled to 'not controlled'

d389ada

This is the beginning of a general performance improvement and also a fix for zulip#2589

borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Jun 21, 2018

Change compose box inputs from controlled to 'not controlled'

85e59b3

This is the beginning of a general performance improvement and also a fix for zulip#2589

borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Jun 21, 2018

Change compose box inputs from controlled to 'not controlled'

99b61af

This is the beginning of a general performance improvement and also a fix for zulip#2589

borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Jun 21, 2018

Change compose box inputs from controlled to 'not controlled'

e39489e

This is the beginning of a general performance improvement and also a fix for zulip#2589

borisyankov mentioned this issue Jun 28, 2018

Make ComposeBox message and topic inputs uncontrolled #2738

Merged

gnprice closed this as completed in #2738 Jun 30, 2018

zulipbot unassigned borisyankov Jun 30, 2018

zulipbot removed the zz-in progress label Jun 30, 2018

gnprice mentioned this issue Jul 11, 2018

Upgrade to RN 0.56 #2788

Closed

gnprice mentioned this issue May 8, 2020

Upgrade to RN v0.61 #3781

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Text input gets very slow on some Android devices #2589

Text input gets very slow on some Android devices #2589

borisyankov commented May 30, 2018 •

edited

Loading

gnprice commented Jun 9, 2018

Text input gets very slow on some Android devices #2589

Text input gets very slow on some Android devices #2589

Comments

borisyankov commented May 30, 2018 • edited Loading

gnprice commented Jun 9, 2018

borisyankov commented May 30, 2018 •

edited

Loading