Skip to content

Commit

Permalink
cleanup: Remove maxHeight prop in Popup component
Browse files Browse the repository at this point in the history
This is not a property that the `View` component supports.
It has never had any effect and now Flow registers it as an error.

Introduced in ce0395cf
  • Loading branch information
borisyankov committed Jul 23, 2018
1 parent b028bec commit 3336c0e
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions src/common/Popup.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* @flow */
import React, { PureComponent } from 'react';
import type { ChildrenArray } from 'react';
import { View, Dimensions, StyleSheet } from 'react-native';
import { View, StyleSheet } from 'react-native';

const styles = StyleSheet.create({
popup: {
Expand All @@ -27,12 +27,8 @@ export default class Popup extends PureComponent<Props> {
};

render() {
const { height } = Dimensions.get('window');

return (
<View style={[this.context.styles.backgroundColor, styles.popup]} maxHeight={height / 4}>
{this.props.children}
</View>
<View style={[this.context.styles.backgroundColor, styles.popup]}>{this.props.children}</View>
);
}
}

0 comments on commit 3336c0e

Please sign in to comment.