New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "validator" lib to reduce node_modules size #9

Open

RollingHog opened this issue Apr 5, 2022 · 0 comments

RollingHog commented Apr 5, 2022 •

edited

Loading

Pretty self-explanatory. I'm sure that "validator" is a good lib, but it is 0.3mb in size. This is way too much for two functions in one file.

My offer is:

replace validator isIP with built-it net.isIP function
replace validator isFQDN with https://www.npmjs.com/package/is-fqdn

If repo owner allows this, I can create a pull request.

Mentioned file is https://github.com/zulhilmizainuddin/nodejs-traceroute/blob/d06023a358434d4db3ceb23a5947c149023b8dd7/process.js

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment