Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable mod_deflate #13

Closed
schmunk42 opened this issue May 20, 2014 · 4 comments
Closed

Disable mod_deflate #13

schmunk42 opened this issue May 20, 2014 · 4 comments

Comments

@schmunk42
Copy link

See these issues: owncloud/client#965 owncloud/core#4783

I am looking for a way to disable it...

@zuazo
Copy link
Owner

zuazo commented May 20, 2014

Can you confirm that the mod_deflate is still a problem? In the words of @karlitschek: Nowadays we no longer do compression with php so mod_deflate should be ok. On my test machine mod_deflate is activated and seems to work fine.

Unfortunately mod_deflate is compulsorily enabled inside the apache2::web_app definition. So perhaps the best way to disable it is adding SetEnv no-gzip 1 to the VirtualHost template.

@schmunk42
Copy link
Author

I can confirm this 100%(!). I double checked it with Safari, Firefox, but it does not happen with wget.

If I use SetEnv no-gzip in the .htaccess file I get the exact file back, checked by its md5.
If I don't enable this option get a slightly smaller file:

78991231 20 Mai 17:08 with-gizp.tar.gz
79320952 20 Mai 17:07 no-gzip.tar.gz

$ md5 with-gizp.tar.gz
c222245d374d63f6f5560c4ad95541db

$ md5 no-gzip.tar.gz
f7a88e46fb62689142ebf24b3592cc3e
$ md5 original-file.tar.gz
f7a88e46fb62689142ebf24b3592cc3e

[update]
further details, see owncloud/core#4783 (comment)

@raulr
Copy link
Contributor

raulr commented May 23, 2014

Hi @schmunk42,

I've made a patch, but tried to disable mod_deflate only on downloads, so the html, css, etc. will still be gzipped: adce32a

Do you think this will be enough or maybe it is better to disable completely?

@schmunk42
Copy link
Author

I think it is enough, if these are all the "exit points" when downloading a file.

Maybe this is also only an issue with .tar.gz files, but someone would have to investigate this in detail, thank you!

@raulr raulr closed this as completed Jun 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants