Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeamSpeak context compat issue #60

Open
magneticflux- opened this issue Jun 29, 2022 · 2 comments
Open

TeamSpeak context compat issue #60

magneticflux- opened this issue Jun 29, 2022 · 2 comments

Comments

@magneticflux-
Copy link
Collaborator

I found this TeamSpeak issue with the context field here: https://github.com/magneticflux-/fabric-mumblelink-mod/issues/79

Remember to include this change for Minecraft 1.19 and later instead of sending an empty context: magneticflux-/fabric-mumblelink-mod@540d29a

@zsawyer
Copy link
Owner

zsawyer commented Feb 8, 2023

This would effect this code

protected String generateContext(Minecraft game, int maxLength) {

or the addon could be extended:
https://github.com/zsawyer/MumbleLink/blob/QnD-MC_JNA/mod/src/main/java/zsawyer/mods/mumblelink/addons/pa/es/ExtendedPASupport.java#L60

However we explicitly did set this to empty at some point.
// empty context because the plugin name is already always prepended anyways

I am not happy with this arbitrariness imposed by TeamSpeak.

@zsawyer
Copy link
Owner

zsawyer commented Feb 4, 2024

Note: hardcode context to be "Context" starting with 1.19.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants