Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to update datasets with VBA Format #467

Open
Colin-Stone opened this issue Jan 24, 2020 · 4 comments
Open

Unable to update datasets with VBA Format #467

Colin-Stone opened this issue Jan 24, 2020 · 4 comments
Labels
bug Something isn't working Datasets priority-low Legit issue but cosmetic or nice-to-have severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex.

Comments

@Colin-Stone
Copy link
Member

Colin-Stone commented Jan 24, 2020

Raised on behalf of customer who believes this function used to work.

It should be possible to edit a VBA dataset.

Create a VBA dataset e.g.
dsname: STONECC.TEST.VBA
blksz: 50
cdate: 2020/01/24
dev: 3390
dsorg: PS
edate: None
extx: 1
lrecl: 0
migr: NO
mvol: N
ovf: NO
rdate: 2020/01/24
recfm: VBA

Edit this file and save. The save operation results in a Http 412 which causes the compare function to be invoked. Etag?

@Colin-Stone Colin-Stone added the bug Something isn't working label Jan 24, 2020
@Colin-Stone
Copy link
Member Author

There appears to be an issue with the etag value. Created a new VB dataset. Updated it once via the Zowe Explorer. All good. Updated second time getting 414. Suspicion that etag is not being updated in node when uploading

@MikeBauerCA MikeBauerCA added this to the Backlog milestone Apr 6, 2020
@stepanzharychevbroadcom
Copy link
Contributor

@Colin-Stone initial results of the research are:
Problem seems to be connected with usage of ASA print control characters for VBA. I created VBA dataset with following set up and it had problem with ETAG verification:
Screenshot 2020-04-08 at 11 22 44
Though for VB Dataset I see no problems at all:
Screenshot 2020-04-08 at 12 34 48

So it seems that ETAG is calculated differently for VBA Datasets while we're trying to do save/download as for the common one, it would explain the situation, also log shows the following picture:

Upload Etag: A0B56CC018A82E76A16531619FAA0536 // Initial upload for empty dataset
Upload Etag: 9685987788AA5DFFECEFE47A208AB5BF // Second upload attempt
Download Etag: 64494D661F8B954F4F19F4E521145D51 // Etag which is returned by server

@stepanzharychevbroadcom
Copy link
Contributor

Additional research results are:
Screenshot 2020-04-08 at 14 50 44
I created FBA Dataset and it has exactly the same problem. So it definitely proofs that the reason for all of those issues is ASA print control. We should figure out some way to align flows for the end users, I would suggest the following ways:

  1. Allow users to do unsafe save which doesn't use ETag only for those A Datasets;
  2. Disallow to do any write/update operations for A Datasets and open them in read-only mode (should be mentioned in documentation);
  3. Do nothing and mention in documentation that we don't support such datasets;

@zdmullen
Copy link
Contributor

zdmullen commented Apr 9, 2020

Thanks to Richelle for finding an issue in the Zowe CLI project that is related to this one: Uploading file to dataset with RECFM=FBA shifts lines one char to the right #537. There is also a linked PMR issue as well, so the team thinks it would be good to vote for the PMR issue, found here: https://www.ibm.com/developerworks/rfe/execute?use_case=viewRfe&CR_ID=137769

@VitGottwald VitGottwald changed the title Unable to update datasets with VBA Format: Possible regression Unable to update datasets with VBA Format May 4, 2020
@JillieBeanSim JillieBeanSim removed this from the Backlog milestone Oct 6, 2022
@zFernand0 zFernand0 added priority-low Legit issue but cosmetic or nice-to-have severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex. labels Jan 17, 2023
@t1m0thyj t1m0thyj moved this from New Issues to Low Priority in Zowe Explorer for VS Code Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Datasets priority-low Legit issue but cosmetic or nice-to-have severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex.
Projects
Status: Low Priority
Development

No branches or pull requests

7 participants