Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot add a second session to tree browsers in Theia #377

Closed
phaumer opened this issue Dec 8, 2019 · 2 comments
Closed

Cannot add a second session to tree browsers in Theia #377

phaumer opened this issue Dec 8, 2019 · 2 comments
Assignees
@phaumer
Labels
bug Something isn't working Theia Issues related to the Extension running in Theia
Milestone
1.1 Release

Comments

@phaumer
Copy link
Member

phaumer commented Dec 8, 2019

There is special code to deal with QuickPicks in Theia for the filters, but not sessions. Hence, the picker always returns undefined.

The code for the three tree is entirely the same and could be refactored to avoid redundancies.
@phaumer
Copy link
Member Author

phaumer commented Dec 8, 2019

You can assign me to this bug. It needs the labels bug and theia.
I started the work in this branch: https://github.com/phaumer/vscode-extension-for-zowe/tree/fix-add-session-theia

@jellypuno jellypuno added bug Something isn't working Theia Issues related to the Extension running in Theia labels Dec 9, 2019
@MikeBauerCA MikeBauerCA added this to the 1.1 Release milestone Dec 9, 2019
This was referenced Dec 9, 2019
Closed
Merged
@phaumer
Copy link
Member Author

phaumer commented Dec 9, 2019

Created this PR for the issue: #382

@phaumer phaumer closed this as completed Dec 11, 2019
@jellypuno jellypuno mentioned this issue Dec 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phaumer phaumer

Labels
bug Something isn't working Theia Issues related to the Extension running in Theia
Projects
None yet
Milestone
1.1 Release
Development

No branches or pull requests
3 participants
@phaumer @MikeBauerCA @jellypuno