-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking Changes in Theia v1.16.0 and above #1493
Comments
|
The good news is that the problem seems fixed now with Theia 1.18 (to be released 9/30). I have not seen, yet what fixed it or caused it to break in 1.16 and 1.17. Hence, we need to leave it open for that investigation. Theia 1.18 will be on VS Code API 1.53.2. Perhaps we should also update to that version? |
I have published a Theia 1.18 docker image now to quay.io. In the future we can automate publishing and we can add more squad members to that zowe-explorer org I created. @JillieBeanSim volunteered to update the GitHub script that runs the Theia test. It would probably a change such as - name: Start Theia
run: docker run --name theia --init -d -p 3000:3000 -v "${PWD}/temp:/home/theia/.theia" quay.io/zowe-explorer/theia:1.18.0 in |
FYI this is how I generated the image git clone [email protected]:theia-ide/theia-apps.git
docker build --build-arg version=latest . -t theiaide/theia:latest
docker tag theiaide/theia:latest quay.io/zowe-explorer/theia:1.18.0
docker login quay.io
docker push quay.io/zowe-explorer/theia:1.18.0 |
The old images on docker hub were now deleted. See here: theia-ide/theia-apps#496 |
@JillieBeanSim I filed this issue against Theia: eclipse-theia/theia#10393 The workaround for now is to add |
The Theia team confirmed that they will not release it in a fix pack release, which means that it could end up broken in a Che release. I therefore propose we do implement the workaround for now as proposed above, @JillieBeanSim. |
Describe the bug
There were breaking changes introduced in the newer versions of Theia 1.16.0 and higher that need to be addressed.
Could be more issues would need investigation. Adding failing theia tests output in comment.
The text was updated successfully, but these errors were encountered: