Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default encoding for I/O operations should be UTF-8 #243

Closed
t1m0thyj opened this issue Dec 15, 2023 · 1 comment · Fixed by #244
Closed

Default encoding for I/O operations should be UTF-8 #243

t1m0thyj opened this issue Dec 15, 2023 · 1 comment · Fixed by #244
Assignees
Labels
bug Something isn't working good first issue Good for newcomers priority-medium severity-medium

Comments

@t1m0thyj
Copy link
Member

Whenever open() is called to open a file, we want to use UTF-8 encoding so that special characters are supported.
The default encoding on Windows is currently CP-1252 (until PEP 686 gets implemented in Python 3.15).

To fix this, we should pass encoding="utf-8" on all open() calls unless the file is opened in binary mode.
For example, the following places should be changed in order to support special characters in z/OS job spool files:


@t1m0thyj t1m0thyj added bug Something isn't working good first issue Good for newcomers priority-medium severity-medium labels Dec 15, 2023
Copy link

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

@t1m0thyj t1m0thyj moved this to Medium Priority in Zowe CLI Squad Dec 26, 2023
@t1m0thyj t1m0thyj linked a pull request Jan 4, 2024 that will close this issue
4 tasks
@github-project-automation github-project-automation bot moved this from Medium Priority to Closed in Zowe CLI Squad Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers priority-medium severity-medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants