Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daemon Mode tests for rust binary on Windows, Linux, Mac #1177

Closed
MikeBauerCA opened this issue Oct 26, 2021 · 1 comment
Closed

Daemon Mode tests for rust binary on Windows, Linux, Mac #1177

MikeBauerCA opened this issue Oct 26, 2021 · 1 comment
Assignees

Comments

@MikeBauerCA
Copy link
Contributor

Create a separate set of automated sanity tests for the rust binary on Windows, Linux, Mac.

@zFernand0
Copy link
Member

zFernand0 commented Nov 2, 2021

Here is a quick Q&A discussed with @t1m0thyj and @awharn 😋

  1. Do we have to build the linux binary in a container?
    a. Option A: Do a simple build from ubuntu-latest for testing purposes
    b. Option B: Create a pre-build job and upload the linux artifact. Then download it from the runs-on: {{ matrix.os }}

  2. Should the testing matrix be a bit more complex and include npm versions (6.x and 8.x)?
    a. Probably not since that will make the build have twice as many runners for every push

  3. Should we remove the npm@7 installation from the CI pipeline?
    a. Yes, at least replace it with NPM 8.x
    b. Another alternative is to use the version of npm that comes with NodeJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants