Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are github branch updates removing DCO signoffs? #2092

Open
1000TurquoisePogs opened this issue Oct 11, 2023 · 6 comments
Open

Are github branch updates removing DCO signoffs? #2092

1000TurquoisePogs opened this issue Oct 11, 2023 · 6 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed question Further information is requested

Comments

@1000TurquoisePogs
Copy link
Member

A few people believe they've witnessed that DCO signoffs were fine on a PR prior to clicking the button to update the branch if it is out of date with the target.
image

After this point, I personally have seen the green check for DCO signoff turn into a red failure where it says DCO is missing.
Unless this is my imagination, it's as if this button can sometimes remove DCO.
Or otherwise, the original DCO check was wrong?

Either way, if people can witness this for certain, please note the PR so that we can send this to whoever is the author of whatever tool (the DCO bot, or github itself).

@1000TurquoisePogs 1000TurquoisePogs added bug Something isn't working help wanted Extra attention is needed question Further information is requested labels Oct 11, 2023
@1000TurquoisePogs
Copy link
Member Author

Adding you John just incase this is due to behavior of github itself since I recall you helped get DCO behavior for us as a sort of pilot/beta program, you might know who to contact if we do spot an issue for sure.

@jmertic
Copy link
Contributor

jmertic commented Oct 12, 2023

@1000TurquoisePogs Can you point me to a PR with this happening? Thanks!

@1000TurquoisePogs
Copy link
Member Author

This just happened. No DCO issue, then click the "update branch" button, then DCO issues on every commit.
Upon checking the commits, I see that the DCO bot returned green for every commit up until the last one, in which it retroactively thinks the commits are now wrong.

https://github.com/zowe/zen/pull/84/commits

@jmertic
Copy link
Contributor

jmertic commented Nov 14, 2023

Thanks @1000TurquoisePogs. I don't see a DCO signoff on any of those commits; are you saying there were DCO signoffs on the commits and they all are gone now?

@jmertic
Copy link
Contributor

jmertic commented Dec 5, 2023

Closing the loop - I'd recommend enabling remediation commits for all repos.

https://github.com/dcoapp/app#individual-remediation-commit-support

This will make it easier to clean up DCO signoffs that are missing.

@jmertic
Copy link
Contributor

jmertic commented Jan 16, 2024

Seeing if this is still an issue - let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants