Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add section for linter output #51

Open
m4r1vs opened this issue Jan 15, 2018 · 7 comments
Open

Feature: add section for linter output #51

m4r1vs opened this issue Jan 15, 2018 · 7 comments
Assignees

Comments

@m4r1vs
Copy link
Collaborator

m4r1vs commented Jan 15, 2018

I think many people would love having the output of a linter such as eslint and/or stylelint in the dashboard. I know it is already implemented fairly good into text editors but I would still love this feature. I will try making a PR soon but if there are any other ideas that are related to this please let me know!

Maybe it doesn't have to be a linter only but rather having the option to specify something like

new Jarvis({
    customCommands: [
        "eslint src --fix",
        "jest test"
    ]
})

And those command then each run on after build via require('child_process').exec and their output gets shown in individual tabs/sections in Jarvis.

@m4r1vs
Copy link
Collaborator Author

m4r1vs commented Jan 15, 2018

Probably having the output of the commands in seperate tabs of the section that displays webpack output would be the best idea since it already looks like a terminal output.

@Sunshine168
Copy link
Contributor

Sunshine168 commented Jan 15, 2018

i think set tabs of the section that displays is a good idea. Provider custom tabs name in option like

new Jarvis({
    customCommands: [
       {name:"eslint ...", cmd:"eslint src --fix",reservedOptions} 
       { name:"test", cmd:"jest test",reservedOptions}
    ],
})

will be funny ?

@m4r1vs
Copy link
Collaborator Author

m4r1vs commented Jan 15, 2018

@Sunshine168 oh yeah that's a good idea to have a specified name, I thought of maybe somehow getting it from the running command but I don't think it's possible

@zouhir
Copy link
Owner

zouhir commented Jan 15, 2018

Great idea!!! 😻😻😻 But actually we don't need to do that in options. Would you consider something like:

// Loop through a projects npm scripts
Object.keys(pkg['scripts']).forEach(K => 

// K = start, test, lint, etc..

// Make a button in the dashboard

// On button click execute PKG[scripts][K in child process
})

I think thatd be RAD!!!

@m4r1vs
Copy link
Collaborator Author

m4r1vs commented Jan 15, 2018

Oh yeah totally forgot that we already have UI where we can do such things in.
Maybe also add option save which then saves the current open commands in
something like .jarvisrc?

@Sunshine168
Copy link
Contributor

oh yeah , Supporting config such as saving or auto-run scripts in ui is useful

@zouhir
Copy link
Owner

zouhir commented Jan 16, 2018

I'm excited for this y'all!

@m4r1vs m4r1vs self-assigned this Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants