Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connector detects invalid proxy when reloading on login page after switching to institutional network #492

Open
AbeJellinek opened this issue Jul 17, 2024 · 1 comment

Comments

@AbeJellinek
Copy link
Member

I've encountered this a couple times when testing translators:

  1. Start on an EZProxy login redirect page, like https://libproxy.berkeley.edu/login?qurl=https://www.proquest.com/archivefinder
  2. Enable a VPN/SOCKS proxy that gives you institutional access
  3. Reload the login page. EZProxy will detect your institutional access and redirect to the qurl page, without any proxy.
  4. The Connector will show a banner prompting you to add %h/%p as a proxy, and Invalid proxy %h/%p: TypeError: parts[1].split(...).pop().match(...) is null will be logged in the Connector error console

Seems like it's detecting the unproxied page as proxied and offering to create a no-op proxy. The prompt probably shouldn't show for no-op proxies / proxies that fail to parse.

@adomasven
Copy link
Member

Ah, I've been for someone to reproduce this for a while! Thanks! Will look into fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants