Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZM is caching #330

Open
Ressy66 opened this issue Jul 17, 2022 · 5 comments
Open

ZM is caching #330

Ressy66 opened this issue Jul 17, 2022 · 5 comments
Labels
T-Question Type: Incoming question

Comments

@Ressy66
Copy link

Ressy66 commented Jul 17, 2022

There are two issues here, and both related, so I will make mention here as they may be related causes.

In previous releases if we edit assets/i18n/en.json , a few refreshes and forced cache expire of browser later, would pick it up.

In the current release this does not happen, no matter what it never changes, this seems to be in the newer files in dists root
i18n-en-json-es201~6606590a7f2fb8.js etc modifying one word in there, eventually is picked up by browsers, these did not exist previously when things worked for customising texts.

Why is there i18n-en-json-es5. version of everything, all this seems unneccessary and adds a lot of complexity finding errors, espeically for those of us who are not json fans/experts/etc.

Please simplify this, and allow somewhere for us to once again over ride your choices, frankly at moment those assets/i18n files may as well not be there, since they are ignored.

As touched on, the other related issue of caching where changes made not picked up, adding a msgbanner and removing it takes forever for some browsers to refresh it (they shouldnt have to force cache flush or force reset), the same applies here for logo, Chrome picks it up right away, firefox, opera and edge, don't unless a lot of forced cache resetrs, except edge, which doesnt change at all.

@Ressy66
Copy link
Author

Ressy66 commented Jul 17, 2022

I will add this is d/l the release package available from git - NOT the source file where we have to build it.

@matsduf matsduf added the T-Question Type: Incoming question label Jul 18, 2022
@matsduf
Copy link
Contributor

matsduf commented Jul 18, 2022

Have you tried to update the source code and then build a new GUI package instead?

@hannaeko
Copy link
Member

hannaeko commented Jul 18, 2022

In the current release this does not happen, no matter what it never changes, this seems to be in the newer files in dists root
i18n-en-json-es201~6606590a7f2fb8.js etc modifying one word in there, eventually is picked up by browsers, these did not exist previously when things worked for customising texts.

Why is there i18n-en-json-es5. version of everything, all this seems unneccessary and adds a lot of complexity finding errors, espeically for those of us who are not json fans/experts/etc.

The new files names are to avoid having the old translations getting cached, these are autogenerated in our build process. I'll have a look to see if it can be done in a more human readable manner.

As touched on, the other related issue of caching where changes made not picked up, adding a msgbanner and removing it takes forever for some browsers to refresh it (they shouldnt have to force cache flush or force reset), the same applies here for logo, Chrome picks it up right away, firefox, opera and edge, don't unless a lot of forced cache resetrs, except edge, which doesnt change at all.

Maybe this would be best done at the web server level (Apache or Nginx) by setting the Cache-Control header. I don't have a example to share at the moment, when I do I will share it. If that works we could update the example Apache configuration to have it included.

@hannaeko
Copy link
Member

hannaeko commented Nov 14, 2022

We are in the process of changing how we handle translation as the previous system has became partially unmaintained.
In the new system (not yet merged in develop), the translation is handled at compile time making it not possible to change some strings just from the release package.

May I ask what were your changes? Did you add a language or did you change some wording? Either way if the changes are relevant to be included in upstream that could be something we could consider doing.

@matsduf
Copy link
Contributor

matsduf commented Sep 8, 2023

@Ressy66, is this still an issue for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Question Type: Incoming question
Projects
None yet
Development

No branches or pull requests

3 participants