$p masking in Zonemaster::Engine::Nameserver #1379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the following warning caught by Debian Perl Team's autopkgtest starting with Zonemaster::Engine 5.0.0: "my" variable $p masks earlier declaration in same scope at /usr/share/perl5/Zonemaster/Engine/Nameserver.pm line 363. This warning occurs because the variable is declared multiple times behind "if" statements, and another time unconditionally later in the subroutine. This patch proceeds to the $p variable declaration earlier in the subroutine unconditionnally, so they are always guaranteed to be available and unmasked. The only drawback is that the $in_cache variable now needs to be declared in a separate statement. Signed-off-by: Étienne Mollier <[email protected]>
tgreenx
requested review from
mattias-p,
matsduf,
tgreenx,
marc-vanderwal and
MichaelTimbert
tgreenx
added
the
V-Patch
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@emollier I am closing this PR, see my response above. |
|
Thanks Thomas for your reviews, and the two other merges!
Note that I have changed the base branch from `master` to
`develop`, which is the branch that should be used for this
project
I adjusted my local copies of Zonemaster::Engine and CLI
repositories to track the "develop" branch by default (and
dropped the "master" branch altogether as I'm tracking CPAN for
releases fit for publication). This should avoid this issue in
the future.
Have a nice day, :)
Étienne.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
Purpose
This change fixes the following warning caught by Debian Perl Team's autopkgtest starting with Zonemaster::Engine 5.0.0:
Context
This warning occurs because the variable is declared multiple times behind "if" statements, and another time unconditionally later in the subroutine.
Changes
This patch proceeds to the $p variable declaration earlier in the subroutine unconditionnally, so they are always guaranteed to be available and unmasked. The only drawback is that the $in_cache variable now needs to be declared in a separate statement.
How to test this PR
Run the test suite, or run syntax checks, and ensure that the warning does not occur anymore in the logs.
Have a nice day, :)
Étienne