Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Basic00 implementation #1308

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Conversation

tgreenx
Copy link
Contributor

@tgreenx tgreenx commented Nov 29, 2023

Purpose

This PR removes the implementation of test case Basic00, as it has been replaced by a new generic module Zonemaster::Engine::Normalization (see #1040).

Context

Usage is done directly by the interfaces, i.e. CLI and Backend.

Changes

  • Remove Basic00 implementation
  • Update unit tests
  • Update documentation

How to test this PR

Unit tests are updated and should pass.

Manual testing:

Basic00 should not be there anymore:

$ git log -1 --oneline
1f4072ad (HEAD -> remove-basic00, origin/remove-basic00) Remove Basic00 Test Case
  1. When running a single test case
$ zonemaster-cli zonemaster.net --no-ipv6 --show-testcase --level INFO --test Basic/basic00
Seconds Level    Testcase       Message
======= ======== ============== =======
   0.00 INFO     Unspecified    Using version v4.7.3 of the Zonemaster engine.
   0.00 CRITICAL Unspecified    Request to run unknown method basic00 in module Zonemaster::Engine::Test::Basic.
  1. When running a single test module
$ zonemaster-cli zonemaster.net --no-ipv6 --show-testcase --level DEBUG --test Basic | grep TEST_CASE
   0.00 DEBUG    Basic01        TEST_CASE_START Basic01.
   7.48 DEBUG    Basic01        TEST_CASE_END Basic01.
   7.48 DEBUG    Basic02        TEST_CASE_START Basic02.
  13.33 DEBUG    Basic02        TEST_CASE_END Basic02.
  1. When running the full test suite
    $ zonemaster-cli zonemaster.net --no-ipv6 --show-testcase --level DEBUG | grep -i Basic00

It has been replaced by a new generic module: Zonemaster::Engine::Normalization.
@tgreenx tgreenx added the A-TestCase Area: Test case specification or implementation of test case label Nov 29, 2023
@tgreenx tgreenx added this to the v2023.2 milestone Nov 29, 2023
mattias-p
mattias-p previously approved these changes Nov 29, 2023
Copy link
Member

@mattias-p mattias-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Of course zonemaster/zonemaster#1226 should be merged simultaneously with this one.

@tgreenx tgreenx merged commit 723cbc2 into zonemaster:develop Dec 4, 2023
3 checks passed
@tgreenx tgreenx deleted the remove-basic00 branch December 4, 2023 11:08
@ghost
Copy link

ghost commented Jan 8, 2024

v2023.2 release testing

Tested following the "How to test" section, works as expected.

@ghost ghost added the S-ReleaseTested Status: The PR has been successfully tested in release testing label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-TestCase Area: Test case specification or implementation of test case S-ReleaseTested Status: The PR has been successfully tested in release testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants