Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incoherent helper function name and message tags in Zone test module #1276

Closed
tgreenx opened this issue Aug 8, 2023 · 1 comment · Fixed by #1296
Closed

Incoherent helper function name and message tags in Zone test module #1276

tgreenx opened this issue Aug 8, 2023 · 1 comment · Fixed by #1296
Assignees
@tgreenx
Labels
A-TestCase Area: Test case specification or implementation of test case S-PRforIssue Status: There is a PR that is meant to resolve the issue
Milestone
v2023.2

Comments

@tgreenx
Copy link
Contributor

tgreenx commented Aug 8, 2023

Currently most Test modules have an internal helper function called _ip_disabled_message(). However, for some reason (I suspect it was copy pasted from the Zonemaster::Engine::Zone module), the one in Zonemaster::Engine::Test:Zone module is called _is_ip_version_disabled(). Moreover, most likely for the same reason, message tags are called SKIP_IPVx_DISABLED instead of IPVx_DISABLED.
@tgreenx tgreenx added the A-TestCase Area: Test case specification or implementation of test case label Aug 8, 2023
@tgreenx tgreenx added this to the v2023.2 milestone Aug 8, 2023
@tgreenx tgreenx self-assigned this Aug 8, 2023
@tgreenx tgreenx mentioned this issue Sep 20, 2023
Merged
@tgreenx tgreenx linked a pull request Sep 20, 2023 that will close this issue
Refactoring of utility function in Zonemaster::Engine::Test::Zone #1296
Merged
@tgreenx tgreenx added the S-PRforIssue Status: There is a PR that is meant to resolve the issue label Sep 20, 2023
@tgreenx
Copy link
Contributor Author

tgreenx commented Oct 10, 2023

Solved by #1296

@tgreenx tgreenx closed this as completed Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tgreenx tgreenx

Labels
A-TestCase Area: Test case specification or implementation of test case S-PRforIssue Status: There is a PR that is meant to resolve the issue
Projects
None yet
Milestone
v2023.2
Development

Successfully merging a pull request may close this issue.

Refactoring of utility function in Zonemaster::Engine::Test::Zone tgreenx/zonemaster-engine
1 participant
@tgreenx