From 6b53599f00c5f0b0a9b8722f71ade90413bc204e Mon Sep 17 00:00:00 2001 From: "[Thomas Green]" Date: Tue, 29 Aug 2023 15:18:42 +0200 Subject: [PATCH 1/8] Fix Basic01 Makes use of the correct variables (fixes #1280) --- lib/Zonemaster/Engine/Test/Basic.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Zonemaster/Engine/Test/Basic.pm b/lib/Zonemaster/Engine/Test/Basic.pm index 388ed944e..54a73ebd9 100644 --- a/lib/Zonemaster/Engine/Test/Basic.pm +++ b/lib/Zonemaster/Engine/Test/Basic.pm @@ -473,13 +473,13 @@ sub basic01 { my $p_a = Zonemaster::Engine::Recursor->recurse( $ns_name, q{A} ); if ( $p_a and $p_a->rcode eq 'NOERROR' ) { - $rrs_ns{$ns_name}{'addresses'}{$_->address} = 1 for $p->get_records_for_name( 'A', $ns_name ); + $rrs_ns{$ns_name}{'addresses'}{$_->address} = 1 for $p_a->get_records_for_name( 'A', $ns_name ); } my $p_aaaa = Zonemaster::Engine::Recursor->recurse( $ns_name, q{AAAA} ); if ( $p_aaaa and $p_aaaa->rcode eq 'NOERROR' ) { - $rrs_ns{$ns_name}{'addresses'}{$_->address} = 1 for $p->get_records_for_name( 'AAAA', $ns_name ); + $rrs_ns{$ns_name}{'addresses'}{$_->address} = 1 for $p_aaaa->get_records_for_name( 'AAAA', $ns_name ); } } From ab8a84e6a461d47dfa234035cd7a9947a9788fe2 Mon Sep 17 00:00:00 2001 From: Marc van der Wal Date: Thu, 31 Aug 2023 10:02:49 +0200 Subject: [PATCH 2/8] Disable blacklisting for queries by NAMESERVER15 Some DNS operate autoritative DNS servers in environments that drop queries performed by the NAMESERVER15 test case, i.e. version.bind/CH/TXT and version.server/CH/TXT. In those setups, the name servers in question could be mistakenly deemed unresponsive, causing subsequent queries not to be attempted at all. This leads to false warnings in other test cases. This commit disables the blacklisting of name servers that do not respond to our version probes, preventing false warnings from being emitted. --- lib/Zonemaster/Engine/Test/Nameserver.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Zonemaster/Engine/Test/Nameserver.pm b/lib/Zonemaster/Engine/Test/Nameserver.pm index 3de532694..63c263ee4 100644 --- a/lib/Zonemaster/Engine/Test/Nameserver.pm +++ b/lib/Zonemaster/Engine/Test/Nameserver.pm @@ -1375,7 +1375,7 @@ sub nameserver15 { my $found_string = 0; foreach my $query_name ( q{version.bind}, q{version.server} ) { - my $p = $ns->query( $query_name, q{TXT}, { class => q{CH} } ); + my $p = $ns->query( $query_name, q{TXT}, { class => q{CH}, blacklisting_disabled => 1 } ); if ( $p and $p->rcode eq q{NOERROR} and scalar $p->get_records_for_name( q{TXT}, $query_name, q{answer} ) ) { foreach my $rr ( $p->get_records_for_name(q{TXT}, $query_name, q{answer} ) ) { From 01a7a00afeb77bb0e8f66b014fd4e3f675d23f30 Mon Sep 17 00:00:00 2001 From: Mats Dufberg Date: Fri, 1 Sep 2023 10:08:17 +0200 Subject: [PATCH 3/8] Updates Changes --- Changes | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Changes b/Changes index fcfcf0349..a4d7d056b 100644 --- a/Changes +++ b/Changes @@ -1,6 +1,15 @@ Release history for Zonemaster component Zonemaster-Engine +v4.7.3 2023-08-07 (public fix version) + + [Fixes] + - Fixes bug (regression) in test case BASIC01 that make tests of zones + fail if the delegation to the zone has no glue record, which is as + expected if the zone has no in-bailiwick NS. The bug was introduced + in version v4.7.2 in release v2023.1.2. (#1282) + + v4.7.2 2023-08-07 (public fix version) [Fixes] From c66e412f019ed6f2d6cdd4d3f06f59e02744c8b2 Mon Sep 17 00:00:00 2001 From: Mats Dufberg Date: Fri, 1 Sep 2023 10:09:12 +0200 Subject: [PATCH 4/8] Sets new version for the release --- lib/Zonemaster/Engine.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Zonemaster/Engine.pm b/lib/Zonemaster/Engine.pm index 3cec9e246..8b4b2abae 100644 --- a/lib/Zonemaster/Engine.pm +++ b/lib/Zonemaster/Engine.pm @@ -1,6 +1,6 @@ package Zonemaster::Engine; -use version; our $VERSION = version->declare("v4.7.2"); +use version; our $VERSION = version->declare("v4.7.3"); use 5.014002; From 8c593c02f630fc84379811ecf76615eed8f2aa35 Mon Sep 17 00:00:00 2001 From: Mats Dufberg Date: Mon, 4 Sep 2023 22:47:53 +0200 Subject: [PATCH 5/8] Updates the Changes file --- Changes | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/Changes b/Changes index a4d7d056b..3f40a4c28 100644 --- a/Changes +++ b/Changes @@ -4,10 +4,12 @@ Release history for Zonemaster component Zonemaster-Engine v4.7.3 2023-08-07 (public fix version) [Fixes] - - Fixes bug (regression) in test case BASIC01 that make tests of zones - fail if the delegation to the zone has no glue record, which is as - expected if the zone has no in-bailiwick NS. The bug was introduced - in version v4.7.2 in release v2023.1.2. (#1282) +- Fixes a bug (regression) in test case BASIC01 that made tests of zones + fail if, while walking the chain of delegations from the root to the + zone under test, a name server returns a referral pointing to name + servers for an intermediate zone which are all out-of-bailiwick and + lacking glue. The bug was introduced in version v4.7.0 in release + v2023.1. v4.7.2 2023-08-07 (public fix version) From a7bd00360707e7c803e813f0fd544e6415050f06 Mon Sep 17 00:00:00 2001 From: Mats Dufberg Date: Tue, 5 Sep 2023 22:25:30 +0200 Subject: [PATCH 6/8] Updates the entry based on review comments --- Changes | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Changes b/Changes index 3f40a4c28..6455b8873 100644 --- a/Changes +++ b/Changes @@ -1,10 +1,10 @@ Release history for Zonemaster component Zonemaster-Engine -v4.7.3 2023-08-07 (public fix version) +v4.7.3 2023-09-05 (public fix version) [Fixes] -- Fixes a bug (regression) in test case BASIC01 that made tests of zones +- Fixes a bug in test case BASIC01 that made tests of zones fail if, while walking the chain of delegations from the root to the zone under test, a name server returns a referral pointing to name servers for an intermediate zone which are all out-of-bailiwick and From 3376b91fe03a9cb25237961bc55294bb88a3c5b9 Mon Sep 17 00:00:00 2001 From: Mats Dufberg Date: Wed, 6 Sep 2023 22:24:22 +0200 Subject: [PATCH 7/8] Adjusts date --- Changes | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Changes b/Changes index 6455b8873..49d7838d3 100644 --- a/Changes +++ b/Changes @@ -1,7 +1,7 @@ Release history for Zonemaster component Zonemaster-Engine -v4.7.3 2023-09-05 (public fix version) +v4.7.3 2023-09-08 (public fix version) [Fixes] - Fixes a bug in test case BASIC01 that made tests of zones From 2bfbecde66394cac96733ea19763b7dd219fcc9e Mon Sep 17 00:00:00 2001 From: Mats Dufberg Date: Thu, 7 Sep 2023 10:04:34 +0200 Subject: [PATCH 8/8] Adds additional change to Changes --- Changes | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Changes b/Changes index 49d7838d3..23395b488 100644 --- a/Changes +++ b/Changes @@ -9,7 +9,9 @@ v4.7.3 2023-09-08 (public fix version) zone under test, a name server returns a referral pointing to name servers for an intermediate zone which are all out-of-bailiwick and lacking glue. The bug was introduced in version v4.7.0 in release - v2023.1. + v2023.1. (#1282) +- Disable blacklisting for queries by NAMESERVER15 to prevent false + errors and warnings (#1285) v4.7.2 2023-08-07 (public fix version)