Related to zonemaster-engine issue 578

[vlevigneron]

• Add method name (test case) in Logger.
• Fixes Extend messages with test case zonemaster-engine#578

DO NOT MERGE NOW, do a test first to check if it is what you are waiting for

[matsduf]

@vlevigneron, does this PR depend on the code change by zonemaster/zonemaster-engine/pull/762?

[matsduf]

I have tested this together with zonemaster/zonemaster-engine#762.

The way it is presented in "normal" view and --jason is fine. If --raw is selcted then --show_testcase gives both test case and module:

# zonemaster-cli zonemaster.net --no-ipv6 --level INFO --show_testcase --raw
   0.00 INFO      SYSTEM:UNSPECIFIED:GLOBAL_VERSION version=v3.1.2
   0.33 INFO      BASIC:BASIC01:HAS_PARENT pname=net; zone=zonemaster.net
   1.57 INFO      BASIC:BASIC02:IPV6_DISABLED address=2001:67c:124c:100a::45; ns=ns.nic.se; rrtype=NS
   1.57 INFO      BASIC:BASIC02:IPV4_ENABLED address=91.226.36.45; ns=ns.nic.se; rrtype=NS
   1.58 INFO      BASIC:BASIC02:HAS_NAMESERVERS address=91.226.36.45; ns=ns.nic.se; nsnlist=ns.nic.se.,ns2.nic.fr.,ns3.nic.se.
   1.58 INFO      BASIC:BASIC02:IPV4_ENABLED address=192.93.0.4; ns=ns2.nic.fr; rrtype=NS
   1.63 INFO      BASIC:BASIC02:HAS_NAMESERVERS address=192.93.0.4; ns=ns2.nic.fr; nsnlist=ns.nic.se.,ns2.nic.fr.,ns3.nic.se.
(...)

Since there is already a show_module options that is unneeded. It is better if --show_testcase just shows the test case. If you want the module too, then you use both options.

# zonemaster-cli --show_module zonemaster.net --no-ipv6 --level INFO --show_testcase --raw
   0.00 INFO      SYSTEM       SYSTEM:UNSPECIFIED:GLOBAL_VERSION version=v3.1.2
   0.28 INFO      BASIC        BASIC:BASIC01:HAS_PARENT pname=net; zone=zonemaster.net
   1.54 INFO      BASIC        BASIC:BASIC02:IPV6_DISABLED address=2001:67c:124c:100a::45; ns=ns.nic.se; rrtype=NS
   1.54 INFO      BASIC        BASIC:BASIC02:IPV4_ENABLED address=91.226.36.45; ns=ns.nic.se; rrtype=NS
   1.55 INFO      BASIC        BASIC:BASIC02:HAS_NAMESERVERS address=91.226.36.45; ns=ns.nic.se; nsnlist=ns.nic.se.,ns2.nic.fr.,ns3.nic.se.
(...)

Secondly, it will be easier to read if the test case is presented as the module, i.e. with space before the message tag. E.g.:

   0.00 INFO      SYSTEM       UNSPECIFIED  GLOBAL_VERSION version=v3.1.2
   0.28 INFO      BASIC        BASIC01      HAS_PARENT pname=net; zone=zonemaster.net
   1.54 INFO      BASIC        BASIC02      IPV6_DISABLED address=2001:67c:124c:100a::45; ns=ns.nic.se; rrtype=NS
   1.54 INFO      BASIC        BASIC02      IPV4_ENABLED address=91.226.36.45; ns=ns.nic.se; rrtype=NS
   1.55 INFO      BASIC        BASIC02      HAS_NAMESERVERS address=91.226.36.45; ns=ns.nic.se; nsnlist=ns.nic.se.,ns2.nic.fr.,ns3.nic.se.
(...)

Thirdly, the new option is available with you run zonemaster-cli -h, but not when you run man zonemaster-cli.

[matsduf]

@vlevigneron, can this be completed?

[vlevigneron]

@matsduf @mattias-p Please review again and check if output is what you are waiting for.

[matsduf]

@mattias-p, can you review again?