-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add headers to every line of multiline log entries #113
Add headers to every line of multiline log entries #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your "patch" does not change anything. There is no difference in output. When I investigate I find that it is line 407 that prints out the lines.
say $translator->translate_tag( $entry );
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--raw
is documented to print raw messages instead of as human language. I feel that it is wrong that --raw
should have other side effects on the output.
I also feel that the new output is problematic for ocular inspection and we need support for that too.
@matsduf |
I will check your branch again to see how it looks like in different cases. |
Rename variables, update whitespace, remove indirection through sprintf.
684d176
to
d34f91b
Compare
I had to rework this PR because the output format of the --raw mode had change, but the effect of the PR is essentially the same. Please re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no specific use case to test against, but it looks OK. The output format of "raw" should be documented in a different PR.
Add headers to all of the lines in
--raw
mode. To tell where new entries begin I added a marker character right after MODULE:TAG. The first line of an entry is marked with an extra SPACE character. The following lines are marked with a '>' character.When you have headers on all lines you can filter the logs with better precision using grep.
Edit: I removed the reference to #111 as this PR solves a different problem.