Use libidn2 instead of libidn #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update Travis dependency * Replace references to "libidn" with "libidn2"
ghost
added this to the 
ghost
requested review from
hannaeko
approved these changes
Apr 28, 2022
matsduf
approved these changes
Apr 28, 2022
| @@ -232,7 +232,7 @@ sub to_idn { | |||
| return Zonemaster::LDNS::to_idn( $str ); | |||
| } | |||
| else { | |||
| warn __( "Warning: Zonemaster::LDNS not compiled with libidn, cannot handle non-ASCII names correctly." ); | |||
| warn __( "Warning: Zonemaster::LDNS not compiled with libidn2, cannot handle non-ASCII names correctly." ); | |||
There was a problem hiding this comment.
I think the following would be better and not bound to details not relevant here.
Warning: Zonemaster::LDNS not compiled with IDN support, cannot handle names with non-ASCII characters correctly.
But I accept as-is.
Compare with zonemaster/zonemaster-cli#254 (comment)
There was a problem hiding this comment.
Good point. I'll do the change in another PR.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Replace libidn with libidn2.
Context
zonemaster/zonemaster-ldns#133
Changes
How to test this PR
Using Zonemaster::LDNS (with libidn2 support), Zonemaster should work the same as before.