Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node-watch warning #671

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

cryptozeny
Copy link

#649

(node:4020) DeprecationWarning: (node-watch) First param in callback function is replaced with event name since 0.5.0, use (evt, filename) => {} if you want to get the filename

zone117x#649

(node:4020) DeprecationWarning: (node-watch) First param in callback function is replaced with event name since 0.5.0, use (evt, filename) => {} if you want to get the filename
@cryptozeny
Copy link
Author

cryptozeny commented Oct 8, 2019

@streetcrypto7
image

Hi, your reference was z-nomp. Its already well known source. You are not invented.
https://github.com/z-classic/z-nomp/blob/104dcf33f649090c2dd6acda6b4aa37ea68c8f55/libs/website.js#L100

    // if an html file was changed reload it
    /* requires node-watch 0.5.0 or newer */
    watch(['./website', './website/pages'], function(evt, filename){
        var basename;
        // support older versions of node-watch automatically
        if (!filename && evt)
            basename = path.basename(evt);
        else
            basename = path.basename(filename);
        
        if (basename in pageFiles){
            readPageFiles([basename]);
            logger.special(logSystem, 'Server', 'Reloaded file ' + basename);
        }
    });

But since its not matched well with current NOMP#dev, and I suggested some changes, but you did not. So I made a new PR to dev branch.
image

I cannot steal your commit, and your opinion is totally nonsense. Whats your problem?

@cryptozeny
Copy link
Author

cryptozeny commented Oct 8, 2019

@streetcrypto7 even your commit was not same as mine.
image

@cryptozeny
Copy link
Author

@streetcrypto7 thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants