Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide whether values and selection sets can be reused past end of field resolution #36

Open
zombiezen opened this issue Dec 25, 2019 · 0 comments
Labels
documentation Improvements or additions to documentation needs-info Further information is needed to move the issue forward
Milestone

Comments

@zombiezen
Copy link
Owner

One thing I've kept unspecified with field resolver methods so far is the lifetime and mutability of the field arguments and selection set passed into the method. (I also haven't specified such bounds on Context, but there's more of a convention around that.) Value and *SelectionSet are intended to be immutable values, so at the moment, there's no harm in keeping a reference to one, but a future version of the library may want to reuse the objects for the purpose of alleviating GC load. If this is something that might be needed, documentation should note it before hitting 1.0.

@zombiezen zombiezen added documentation Improvements or additions to documentation needs-info Further information is needed to move the issue forward labels Dec 25, 2019
@zombiezen zombiezen added this to the Stable milestone Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation needs-info Further information is needed to move the issue forward
Projects
None yet
Development

No branches or pull requests

1 participant