Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address GraphQL string literals with characters outside BMP #34

Open
zombiezen opened this issue Dec 24, 2019 · 0 comments
Open

Address GraphQL string literals with characters outside BMP #34

zombiezen opened this issue Dec 24, 2019 · 0 comments
Labels
needs-info Further information is needed to move the issue forward spec-compliance Areas where this library does not comply with the June 2018 GraphQL specification

Comments

@zombiezen
Copy link
Owner

In 21755d8, I added a TODO for stringification on the test case of scalars with characters outside the Unicode Basic Multilingual Plane.

{
// TODO(someday): This behavior is not fully specified.
// See https://github.com/graphql/graphql-spec/issues/214
name: "String/OutsideBMP",
value: testStringValue("\U00010000"),
want: `"\ud800\udc00"`,
},

This isn't specified upstream, see graphql/graphql-spec#214. There are likely issues with parsing such characters as well, so I should add more tests on the parser.

@zombiezen zombiezen added needs-info Further information is needed to move the issue forward spec-compliance Areas where this library does not comply with the June 2018 GraphQL specification labels Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-info Further information is needed to move the issue forward spec-compliance Areas where this library does not comply with the June 2018 GraphQL specification
Projects
None yet
Development

No branches or pull requests

1 participant