Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub PR: username in document.title is not redacted #39

Open
caugner opened this issue Jul 15, 2018 · 1 comment
Open

GitHub PR: username in document.title is not redacted #39

caugner opened this issue Jul 15, 2018 · 1 comment

Comments

@caugner
Copy link

caugner commented Jul 15, 2018 •
edited
Loading

Just noticed that GitHub puts the username in document.title, and blind-reviews doesn't redact it:
image
@zombie
Copy link
Owner

zombie commented Jul 15, 2018

Ah, that part of the tab title is rarely visible, good catch. Might be a bit tricky to fix because of the lack of structure (in combination with GitHub's use of history.pushState()), but should be doable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zombie @caugner