Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to redact user picture when PR changes #37

Open
allan-silva opened this issue Apr 13, 2018 · 5 comments
Open

Consider to redact user picture when PR changes #37

allan-silva opened this issue Apr 13, 2018 · 5 comments

Comments

@allan-silva
Copy link

Consider to redact user picture when PR changes.
E.g.: Title change, labels added, etc.

image

@zombie
Copy link
Owner

zombie commented Apr 15, 2018

Hey @allan-silvawhat, thanks for reporting. Can you please share the url of that PR, so that I can investigate?

@allan-silva
Copy link
Author

@zombie sorry, I forgot to tell, this is a private repo from my company.

@tie-rack
Copy link

@zombie Here's an example of a PR that demonstrates this: votinginfoproject/sms-web#5

The review request shows the user's icon and can be hovered to see their profile.

@zombie
Copy link
Owner

zombie commented Apr 27, 2018

Thanks, I've already found and fixed the issue, and have been testing it locally, just forgot to update here.

The fix should be in the next week update on AMO.

@allan-silva
Copy link
Author

@zombie, today showing your plugin to a friend, I realized the now author is redacted when PR changes., that is great! One more point is when mouse over the redacted icon:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants