Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caution: Changes to profile settings.yml deletes hooks #69

Open
TonyGravagno opened this issue Sep 5, 2024 · 1 comment
Open

Caution: Changes to profile settings.yml deletes hooks #69

TonyGravagno opened this issue Sep 5, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@TonyGravagno
Copy link

If you change the settings.yml file that points to the local Git repo workspace, the entire repo is removed and replaced. That means your hooks all get deleted. This happens when a 'rm' is issued on the repo folder.

The 'rm' is issued on any update of that file, whether deleting whitespace or changing a message for init or update.

So backup your live custom hooks that replace the built-in .sample files.
A good way to do this might be to edit your user settings.json and add to "syncSettings.additionalFiles" the local path to the folder where you maintain your hook scripts.

For this extension, perhaps a warning can be issued if there are any files in the repository/.git/hooks folder that do not have a .sample extension: (rm *.sample and then select the folder to see if there is still even a single file).
Or just add a warning to the README, which is the best place for warnings like this.

@daiyam
Copy link
Member

daiyam commented Sep 5, 2024

That means your hooks all get deleted.

I think that shouldn't happened....

@daiyam daiyam added the bug Something isn't working label Sep 5, 2024
@daiyam daiyam self-assigned this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants