Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-upload hook not properly awaiting termination of hook action before upload is started #45

Open
cMon95 opened this issue Mar 29, 2023 · 1 comment
Assignees

Comments

@cMon95
Copy link

cMon95 commented Mar 29, 2023

I am trying to manipulate a json file in a pre-upload hook and then sync the file as an additional file. However, the upload process starts before the hook action is terminated and the original json is therefore uploaded, instead of the manipulated json. I am using a powershell script to manipulate the file, use the pre-upload hook in the settings.yml file and utilize a remote repo. This can be replicated by creating a script that simply waits 5-10 seconds (Start-Sleep -Seconds 5), where it can be observed that the success message "Your settings have been uploaded (user -> repository)" appears before the script terminates in the terminal.

@daiyam
Copy link
Member

daiyam commented Mar 29, 2023

Ya, I haven't thought of that...

@daiyam daiyam self-assigned this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants