Fix title and message for Firebase #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can the usage of title and body in remote notifications be explained in the README? I couldn't find a reference to it. |
|
@schumannd The title and body have to be specified in the Firebase payloads |
|
so it does not work with GCM? What about the 'message' key? |
|
Not sure about GCM but this PR is specific to FCM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
titleandbodyare special props when coming from GCM/Firebase compat. Their keys are prefixed withgcm.which is ignored whengetData()returns it's data.We have to use the remote notification APIs to get access to those properties.
I've added these new props before iterating the data bundle so data can override this, making this change backward-compatible.