Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mini-feat(docs) Troubleshooting: Added a note on the experimental bluetooth connection options #2387

Merged
merged 7 commits into from
Jul 25, 2024

Conversation

Nick-Munnich
Copy link
Contributor

Under the connection-issues subsection of troubleshooting there is now a new section and a few sentences.

@Nick-Munnich Nick-Munnich requested a review from a team as a code owner July 22, 2024 16:57
@caksoylar
Copy link
Contributor

Would fix #2170.

@caksoylar caksoylar added the documentation Improvements or additions to documentation label Jul 22, 2024
@caksoylar caksoylar self-assigned this Jul 22, 2024
zmk-modules Outdated Show resolved Hide resolved
@Nick-Munnich
Copy link
Contributor Author

Adjusted as per Discord conversation.

Copy link
Contributor

@caksoylar caksoylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Can I also ask you to move "Issues With Dual Boot Setups" under this header? It's technically an "unable to connect" issue.

Also a note (for this PR or a future one): The description of CONFIG_ZMK_BLE_EXPERIMENTAL_CONN should be updated since it only includes the 2M change right now (after Zephyr 3.5 upgrade), AFAIK.

docs/docs/troubleshooting/connection-issues.mdx Outdated Show resolved Hide resolved
@Nick-Munnich
Copy link
Contributor Author

Requested changes have been made.

Copy link
Contributor

@caksoylar caksoylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate it!

@caksoylar caksoylar merged commit fd152ba into zmkfirmware:main Jul 25, 2024
7 checks passed
flolbr pushed a commit to flolbr/zmk that referenced this pull request Jul 28, 2024
Nick-Munnich added a commit to Nick-Munnich/zmk that referenced this pull request Aug 3, 2024
@Nick-Munnich Nick-Munnich deleted the tbs-conn-exp branch August 14, 2024 14:06
lammai pushed a commit to lammai/zmk that referenced this pull request Oct 27, 2024
EnotionZ pushed a commit to EnotionZ/zmk that referenced this pull request Nov 6, 2024
earwin pushed a commit to earwin/zmk that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants