feat(types): impl PartialEq and Hash for Ident instead of ModulePath
#108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lePath` This follows the original implementation. 2 `Ident`s should be equal if their values are equal, even if their `Span`s are different. This also includes manually implementing `Hash` to allow for this.
mimoo
reviewed
Jun 9, 2024
src/parser/types.rs
Outdated
| impl Hash for Ident { | ||
| fn hash<H: Hasher>(&self, state: &mut H) { | ||
| self.value.hash(state); | ||
| self.span.hash(state); |
There was a problem hiding this comment.
I think the TODO was explicitly about not having the span in the hash :o
There was a problem hiding this comment.
btw I think this solution would be cleaner: https://users.rust-lang.org/t/rust-crate-for-ignore-this-field-for-eq-partialeq-hash/33651/6
There was a problem hiding this comment.
Hmm I see, I misunderstood the intention. I can fix it in this PR (or restore the TODO if that's preferable).
I think the derivative crate is unmaintained and still uses syn v1, so that may not be a great idea. However an alternative (educe) was also presented in that issue, and that uses syn v2. We can bring that in, if this is preferable over manual implementation(s).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #100
This follows the original implementation. 2
Idents should be equal if their values are equal, even if theirSpans are different. This also includes manually implementingHashto allow for this.