Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous TODO in ff_derive #107

Open
CPerezz opened this issue Jun 7, 2023 · 0 comments
Open

Ambiguous TODO in ff_derive #107

CPerezz opened this issue Jun 7, 2023 · 0 comments

Comments

@CPerezz
Copy link

CPerezz commented Jun 7, 2023

In https://github.com/zkcrypto/ff/blob/e853770f4843e47cd5e07330140b5bd1cdfc9f11/ff_derive/src/lib.rs#LL130C27-L130C36 is mentioned that the generator should be computed by the code instead of being given by the macro caller.

The thing is that I'm not sure how are we supposed to pick a generator when we can have an insane amount of possible valid choices. Is there any logic like picking the lowest or similar that you were thinking on applying here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant