Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Titles inside markdown links breaks LSP link completion #435

Open
2 tasks done
tjex opened this issue Jul 15, 2024 · 2 comments
Open
2 tasks done

Titles inside markdown links breaks LSP link completion #435

tjex opened this issue Jul 15, 2024 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@tjex
Copy link
Member

tjex commented Jul 15, 2024

Check if applicable

  • I have searched the existing issues (required)
  • I'm willing to help fix the problem and contribute a pull request

Describe the bug

Related to #436

As was uncovered during discussion here: zk-org/zk-nvim#176 (reply in thread)

The trigger pattern outlined here for regular markdown links is not triggering lsp completion properly.

We have previously looked at a similar issue with wikilink completion: zk-org/zk#397

How to reproduce?

  1. open a note
  2. type [link]((

LSP completion should trigger.

zk configuration

n/a. (although `link-format` in config will define how the link is subsequently inserted).

Environment

zk 0.14.1
system: Darwin 23.4.0 arm64
@vandalt
Copy link

vandalt commented Jul 30, 2024

I just wanted to mention I also get this behavior. More specifically:

  • Completion does not trigger when I do something like: [a link]((
  • However, it does trigger when there is a space before the ](( completion pattern. So doing some text ](( triggers completion.
    • This removes the square bracket, when accepting the completion, however, leaving something like some text(path-to-file)

I cannot reproduce the issue reported in #436, however (I'm on version 0.14.1, not the main branch).

@tjex
Copy link
Member Author

tjex commented Aug 17, 2024

Thanks for reporting. Your tests seem to be consistent with another user here: zk-org/zk-nvim#176 (reply in thread)

@tjex tjex changed the title Markdown link completion for regular markdown links has stopped working Titles inside markdown links breaks LSP link completion Aug 17, 2024
@tjex tjex added the bug Something isn't working label Aug 17, 2024
@tjex tjex added this to the 0.14.2 milestone Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants