Stack Overflow for very simple code

[andrew-pa]

This code runs but then panics with thread 'main' has overflowed its stack:

extern crate zip;

use zip::*;
use zip::write::*;
use std::io::Write;

fn main() {
    let mut out = ZipWriter::new(std::fs::File::create("out.zip").expect("create file"));
    out.start_file("test.txt", FileOptions::default());
    write!(out, "Hello, World!");
}

If you change it to use CompressionMethod::Stored instead, then it works just fine. Older versions before the feature-gated deflate compression seem to also work, as does bzip2 and running in Release mode. Perhaps the deflate code is too deep when unoptimized, with the new feature-gating tricking the compiler somehow? Perhaps that makes it a flate2 issue? I'm also on Windows

[mvdnes]

The flate2 implementation has some very large structures, which are all placed on the stack currently.
In debug mode, the size of the initial stack is too small on Windows. Your example works fine in release mode.

I have submitted an issue as Frommi/miniz_oxide#21

[andrew-pa]

Cool! Thank you!

[mvdnes]

With miniz_oxide 0.1.3, this issue seems to be resolved.