You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Version: 3.5.2 (2.13.x) Module: quill-finagle Database: mysql
Expected behavior
I could manually close the cursor from Finagle.
Actual behavior
The stream operator on the finagle based contexts return an AsyncStream. It is impossible to manually close the context (say if you don't read the full stream).
I think we should change the public API to return a CursorResult[T] instead, so we have control over closing it.
Workaround
I tried to override the context and override the type member but I don't think that's possible and I definitely could not get it to compile.
@getquill/maintainers
The text was updated successfully, but these errors were encountered:
Version: 3.5.2 (2.13.x)
Module: quill-finagle
Database: mysql
Expected behavior
I could manually close the cursor from Finagle.
Actual behavior
The stream operator on the finagle based contexts return an AsyncStream. It is impossible to manually close the context (say if you don't read the full stream).
I think we should change the public API to return a
CursorResult[T]
instead, so we have control over closing it.Workaround
I tried to override the context and override the type member but I don't think that's possible and I definitely could not get it to compile.
@getquill/maintainers
The text was updated successfully, but these errors were encountered: