Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to manually close the cursor in finagle based streaming #2261

Closed
dispalt opened this issue Sep 24, 2021 · 2 comments
Closed

Unable to manually close the cursor in finagle based streaming #2261

dispalt opened this issue Sep 24, 2021 · 2 comments

Comments

@dispalt
Copy link

dispalt commented Sep 24, 2021

Version: 3.5.2 (2.13.x)
Module: quill-finagle
Database: mysql

Expected behavior

I could manually close the cursor from Finagle.

Actual behavior

The stream operator on the finagle based contexts return an AsyncStream. It is impossible to manually close the context (say if you don't read the full stream).

I think we should change the public API to return a CursorResult[T] instead, so we have control over closing it.

Workaround

I tried to override the context and override the type member but I don't think that's possible and I definitely could not get it to compile.

@getquill/maintainers

@jilen
Copy link
Collaborator

jilen commented Sep 27, 2021

Combinator like AsyncStream.takeWhile might help.

@juliano
Copy link
Collaborator

juliano commented Jul 22, 2023

Closed once finagle modules have been dropped

@juliano juliano closed this as completed Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants