Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean IVF_FLAT_NM compatible codes #856

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cydrain
Copy link
Collaborator

@cydrain cydrain commented Sep 20, 2024

issue: #30

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cydrain
Copy link
Collaborator Author

cydrain commented Sep 20, 2024

/hold

will merge for Milvus 3.0
need do compatible test with Milvus

Copy link

mergify bot commented Sep 20, 2024

@cydrain 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@cydrain
Copy link
Collaborator Author

cydrain commented Sep 20, 2024

/kind improvement

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.87%. Comparing base (3c46f4c) to head (73f5315).
Report is 256 commits behind head on main.

Current head 73f5315 differs from pull request most recent head 737daac

Please upload reports for the commit 737daac to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #856       +/-   ##
=========================================
+ Coverage      0   75.87%   +75.87%     
=========================================
  Files         0       86       +86     
  Lines         0     6262     +6262     
=========================================
+ Hits          0     4751     +4751     
- Misses        0     1511     +1511     

see 86 files with indirect coverage changes

---- 🚨 Try these New Features:

@alexanderguzhva
Copy link
Collaborator

/lgtm

@liliu-z
Copy link
Collaborator

liliu-z commented Nov 4, 2024

/reopen

@sre-ci-robot sre-ci-robot reopened this Nov 4, 2024
@sre-ci-robot
Copy link
Collaborator

@liliu-z: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mergify mergify bot removed the ci-passed label Nov 4, 2024
@github-actions github-actions bot removed the stale label Nov 5, 2024
@alexanderguzhva
Copy link
Collaborator

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants